Re: [B.A.T.M.A.N.] [PATCH 2/4] batman: don't bother flipping ->tt_crc

Antonio Quartulli
2012-04-19T05:49:49Z

[-- Attachment #1: Type: text/plain, Size: 688 bytes --]

On Thu, Apr 19, 2012 at 07:41:14AM +0200, Antonio Quartulli wrote:
> On Wed, Apr 18, 2012 at 07:10:58 +0100, Al Viro wrote:
> > @@ -722,7 +721,7 @@ update_tt:
> > tt_update_orig(bat_priv, orig_node, tt_buff,
> > batman_ogm_packet->tt_num_changes,
> > batman_ogm_packet->ttvn,
> > - batman_ogm_packet->tt_crc);
> > + ntohs(batman_ogm_packet->tt_crc));
>
> If we don't need to flip tt_crc, wy are you introducing ntohs here? Am I
> overlooking something?

Ok. I was missing the correct meaning of __be16. Now everything is clear.

Cheers,

--
Antonio Quartulli

..each of us alone is worth nothing..
Ernesto "Che" Guevara

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]