Re: [B.A.T.M.A.N.] [PATCH 1/5] batman-adv: don't bother flipping ->tt_data

Marek Lindner
2012-04-25T12:11:47Z

Hey,

I was about to merge the patch when I realized checkpatch is complaining. See
below for details.

> @@ -618,7 +615,7 @@ int recv_tt_query(struct sk_buff *skb, struct
> hard_iface *recv_if) if (skb_linearize(skb) < 0)
> goto out;
>
> - tt_len = tt_query->tt_data * sizeof(struct tt_change);
> + tt_len = ntohs(tt_query->tt_data) * sizeof(struct tt_change);

Line is too long.

> @@ -1727,7 +1727,7 @@ void handle_tt_response(struct bat_priv *bat_priv,
>
> bat_dbg(DBG_TT, bat_priv,
> "Received TT_RESPONSE from %pM for ttvn %d t_size: %d [%c]\n",
> - tt_response->src, tt_response->ttvn, tt_response->tt_data,
> + tt_response->src, tt_response->ttvn, ntohs(tt_response->tt_data),
> (tt_response->flags & TT_FULL_TABLE ? 'F' : '.'));
>
> /* we should have never asked a backbone gw */
> @@ -1741,7 +1741,7 @@ void handle_tt_response(struct bat_priv *bat_priv,
> if (tt_response->flags & TT_FULL_TABLE)
> tt_fill_gtable(bat_priv, tt_response);
> else
> - tt_update_changes(bat_priv, orig_node, tt_response->tt_data,
> + tt_update_changes(bat_priv, orig_node, ntohs(tt_response->tt_data),
> tt_response->ttvn,
> (struct tt_change *)(tt_response + 1));

Both changes are too long as well.

Regards,
Marek