From: Marek Lindner <lindner_marek@yahoo.de>
To: The list for a Better Approach To Mobile Ad-hoc Networking
<b.a.t.m.a.n@lists.open-mesh.org>
Subject: Re: [B.A.T.M.A.N.] [PATCHv3] batman-adv: Add get_ethtool_stats() support
Date: Fri, 20 Apr 2012 16:13:05 +0800 [thread overview]
Message-ID: <201204201613.05738.lindner_marek@yahoo.de> (raw)
In-Reply-To: <1334756157-7257-1-git-send-email-martin@hundeboll.net>
On Wednesday, April 18, 2012 21:35:57 Martin Hundebøll wrote:
> Added additional counters in a bat_stats structure, which are exported
> through the ethtool api. The counters are specific to batman-adv and
> includes:
> forwarded packets
> management packets (OGMs at this point)
> translation table packets
> distributed arp table packets
>
> I would like you all to check if the increments are added at the right
> locations and also if more counters would be relevant. (E.g. in bridge
> loop avoidance code?)
>
> This is the reworked approach from the previous stat counters patch I
> send, where ethtool stats was suggested.
This patch looks pretty good! I'd say we can merge it unless someone objects?!
Would it possible to count the number of bytes for the forwarded packets in
addition to the packet count ? As I recall you also wanted to move
free_percpu() into mesh_free() ?
Regards,
Marek
next prev parent reply other threads:[~2012-04-20 8:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-16 23:24 [B.A.T.M.A.N.] [PATCH] batman-adv: Add get_ethtool_stats() support Martin Hundebøll
2012-04-17 7:12 ` Antonio Quartulli
2012-04-17 7:25 ` Antonio Quartulli
2012-04-17 13:22 ` Martin Hundebøll
2012-04-17 8:19 ` Marek Lindner
2012-04-17 13:24 ` Martin Hundebøll
2012-04-17 13:29 ` Antonio Quartulli
2012-04-17 16:52 ` [B.A.T.M.A.N.] [PATCHv2] " Martin Hundebøll
2012-04-18 13:35 ` [B.A.T.M.A.N.] [PATCHv3] " Martin Hundebøll
2012-04-20 8:13 ` Marek Lindner [this message]
2012-04-20 15:02 ` [B.A.T.M.A.N.] [PATCHv4] " Martin Hundebøll
2012-04-22 9:03 ` Marek Lindner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201204201613.05738.lindner_marek@yahoo.de \
--to=lindner_marek@yahoo.de \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox