Re: [B.A.T.M.A.N.] [PATCHv3] batman-adv: Add get_ethtool_stats() support

Marek Lindner
2012-04-20T08:13:05Z

On Wednesday, April 18, 2012 21:35:57 Martin Hundebøll wrote:
> Added additional counters in a bat_stats structure, which are exported
> through the ethtool api. The counters are specific to batman-adv and
> includes:
> forwarded packets
> management packets (OGMs at this point)
> translation table packets
> distributed arp table packets
>
> I would like you all to check if the increments are added at the right
> locations and also if more counters would be relevant. (E.g. in bridge
> loop avoidance code?)
>
> This is the reworked approach from the previous stat counters patch I
> send, where ethtool stats was suggested.

This patch looks pretty good! I'd say we can merge it unless someone objects?!

Would it possible to count the number of bytes for the forwarded packets in
addition to the packet count ? As I recall you also wanted to move
free_percpu() into mesh_free() ?

Regards,
Marek