From: Antonio Quartulli <ordex@autistici.org>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, b.a.t.m.a.n@lists.open-mesh.org
Subject: Re: [B.A.T.M.A.N.] [PATCH 06/15] batman-adv: Distributed ARP Table - add snooping functions for ARP messages
Date: Tue, 1 May 2012 00:22:30 +0200 [thread overview]
Message-ID: <20120430222226.GB21977@ritirata.org> (raw)
In-Reply-To: <20120430.130555.48557916635285475.davem@davemloft.net>
[-- Attachment #1: Type: text/plain, Size: 2196 bytes --]
On Mon, Apr 30, 2012 at 01:05:55 -0400, David Miller wrote:
> From: Antonio Quartulli <ordex@autistici.org>
> Date: Sun, 29 Apr 2012 10:57:38 +0200
>
> > In case of an ARP message going in or out the soft_iface, it is intercepted and
> > a special action is performed. In particular the DHT helper functions previously
> > implemented are used to store all the ARP entries belonging to the network in
> > order to provide a fast and unicast lookup instead of the classic broadcast
> > flooding mechanism.
> > Each node stores the entries it is responsible for (following the DHT rules) in
> > its soft_iface ARP table. This makes it possible to reuse the kernel data
> > structures and functions for ARP management.
> >
> > Signed-off-by: Antonio Quartulli <ordex@autistici.org>
>
> Sorry, I'm not letting subsystems outside of net/ipv4/arp.c and related
> code make changes to the ARP table.
>
> I plan to make major surgery to the way neighbour table entries are
> handled and therefore the less people who get their grubby paws
> directly in there, the better.
>
> Find a way to propagate the ARP packet into the properl ARP receive
> path to cause the state update to occur, I'm not letting you trigger
> it by hand in the batman-adv code.
>
> Sorry.
Hello David,
I perfectly understand. We did it that way because we thought that we could use
the exported API.
At this point, in my honest opinion, it is better to postpone this new feature
for a later pull request.
However this patch also contains a procedure which queries the neigh table in
order to understand whether a given host is known or not.
Would it be possible to do that in another way (Without manually touching the
table)?
Instead, in the next patch (patch 06/15) batman-adv manually increase the neigh
timeouts. Do you think we should avoid doing that as well? If we are allowed to
do that, how can we perform the same operation in a cleaner way?
Last question: why can't other modules use exported functions? Are you going to
change them as well?
Thank you very much,
--
Antonio Quartulli
..each of us alone is worth nothing..
Ernesto "Che" Guevara
[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]
next prev parent reply other threads:[~2012-04-30 22:22 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-29 8:57 [B.A.T.M.A.N.] pull request: batman-adv 2012-04-29 Antonio Quartulli
2012-04-29 8:57 ` [B.A.T.M.A.N.] [PATCH 01/15] batman-adv: add UNICAST_4ADDR packet type Antonio Quartulli
2012-04-29 8:57 ` [B.A.T.M.A.N.] [PATCH 02/15] batman-adv: add a new log level for DAT debugging Antonio Quartulli
2012-04-29 8:57 ` [B.A.T.M.A.N.] [PATCH 03/15] batman-adv: add biggest_unsigned_int(x) macro Antonio Quartulli
2012-04-29 8:57 ` [B.A.T.M.A.N.] [PATCH 04/15] batman-adv: Distributed ARP Table - create DHT helper functions Antonio Quartulli
2012-04-29 8:57 ` [B.A.T.M.A.N.] [PATCH 05/15] batman-adv: Distributed ARP Table - add ARP parsing functions Antonio Quartulli
2012-04-29 8:57 ` [B.A.T.M.A.N.] [PATCH 06/15] batman-adv: Distributed ARP Table - add snooping functions for ARP messages Antonio Quartulli
2012-04-30 17:05 ` David Miller
2012-04-30 22:22 ` Antonio Quartulli [this message]
2012-05-01 0:59 ` David Miller
2012-05-12 8:26 ` Marek Lindner
2012-05-17 11:53 ` Marek Lindner
2012-05-23 21:48 ` Simon Wunderlich
2012-05-23 23:01 ` David Miller
2012-05-24 5:34 ` Sven Eckelmann
2012-05-24 5:54 ` David Miller
2012-05-24 8:09 ` Simon Wunderlich
2012-04-29 8:57 ` [B.A.T.M.A.N.] [PATCH 07/15] batman-adv: Distributed ARP Table - increase default soft_iface ARP table timeout Antonio Quartulli
2012-04-29 8:57 ` [B.A.T.M.A.N.] [PATCH 08/15] batman-adv: Distributed ARP Table - add compile option Antonio Quartulli
2012-04-29 8:57 ` [B.A.T.M.A.N.] [PATCH 09/15] batman-adv: fix wrong dhcp option list browsing Antonio Quartulli
2012-04-29 8:57 ` [B.A.T.M.A.N.] [PATCH 10/15] batman-adv: introduce is_single_hop_neigh variable to increase readability Antonio Quartulli
2012-04-29 8:57 ` [B.A.T.M.A.N.] [PATCH 11/15] batman-adv: introduce packet type handler array for incoming packets Antonio Quartulli
2012-04-29 8:57 ` [B.A.T.M.A.N.] [PATCH 12/15] batman-adv: register batman ogm receive function during protocol init Antonio Quartulli
2012-04-29 8:57 ` [B.A.T.M.A.N.] [PATCH 13/15] batman-adv: rename last_valid to last_seen Antonio Quartulli
2012-04-29 8:57 ` [B.A.T.M.A.N.] [PATCH 14/15] batman-adv: replace HZ calculations with jiffies_to_msecs() Antonio Quartulli
2012-04-29 8:57 ` [B.A.T.M.A.N.] [PATCH 15/15] batman-adv: split neigh_new function into generic and batman iv specific parts Antonio Quartulli
-- strict thread matches above, loose matches on Subject: below --
2012-04-25 13:26 [B.A.T.M.A.N.] pull request: batman-adv 2012-04-25 Antonio Quartulli
2012-04-25 13:27 ` [B.A.T.M.A.N.] [PATCH 06/15] batman-adv: Distributed ARP Table - add snooping functions for ARP messages Antonio Quartulli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120430222226.GB21977@ritirata.org \
--to=ordex@autistici.org \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox