From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <lindner_marek@yahoo.de>
From: Marek Lindner <lindner_marek@yahoo.de>
Date: Fri, 4 May 2012 15:34:18 +0800
References: <1335690403-25228-1-git-send-email-sven@narfation.org>
In-Reply-To: <1335690403-25228-1-git-send-email-sven@narfation.org>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: 7bit
Message-Id: <201205041534.18504.lindner_marek@yahoo.de>
Subject: Re: [B.A.T.M.A.N.] [RFC 1/2] batman-adv: Free local translation
	table on error in tt_init
Reply-To: The list for a Better Approach To Mobile Ad-hoc Networking
	<b.a.t.m.a.n@lists.open-mesh.org>
List-Id: The list for a Better Approach To Mobile Ad-hoc Networking
	<b.a.t.m.a.n.lists.open-mesh.org>
List-Unsubscribe: <https://lists.open-mesh.org/mm/options/b.a.t.m.a.n>,
	<mailto:b.a.t.m.a.n-request@lists.open-mesh.org?subject=unsubscribe>
List-Archive: <http://lists.open-mesh.org/pipermail/b.a.t.m.a.n>
List-Post: <mailto:b.a.t.m.a.n@lists.open-mesh.org>
List-Help: <mailto:b.a.t.m.a.n-request@lists.open-mesh.org?subject=help>
List-Subscribe: <https://lists.open-mesh.org/mm/listinfo/b.a.t.m.a.n>,
	<mailto:b.a.t.m.a.n-request@lists.open-mesh.org?subject=subscribe>
To: The list for a Better Approach To Mobile Ad-hoc Networking <b.a.t.m.a.n@lists.open-mesh.org>

On Sunday, April 29, 2012 17:06:42 Sven Eckelmann wrote:
> Signed-off-by: Sven Eckelmann <sven@narfation.org>
> ---
>  translation-table.c |    4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/translation-table.c b/translation-table.c
> index 88c62f1..c3b7773 100644
> --- a/translation-table.c
> +++ b/translation-table.c
> @@ -1776,8 +1776,10 @@ int tt_init(struct bat_priv *bat_priv)
>  	if (!tt_local_init(bat_priv))
>  		return 0;
> 
> -	if (!tt_global_init(bat_priv))
> +	if (!tt_global_init(bat_priv)) {
> +		tt_local_table_free(bat_priv);
>  		return 0;
> +	}
> 
>  	tt_start_timer(bat_priv);

Is this really necessary ? If tt_init() fails mesh_free() is called to free 
all tt buffers / lists / hashes. This is how the other *_init() function calls 
do it as well.

Regards,
Marek