Re: [B.A.T.M.A.N.] [PATCH 07/14] batman-adv: split neigh_new function into generic and batman iv specific parts

Sven Eckelmann
2012-05-10T07:34:25Z

[-- Attachment #1: Type: text/plain, Size: 753 bytes --]

On Wednesday, May 09, 2012 08:41:11 PM David Miller wrote:
[...]
> The namespace pollution of the batman-adv code needs to improve,
> and I'm putting my foot down starting with this change.
>
> If you have a static function which is therefore private to a
> source file, name it whatever you want.
>
> But once it gets exported out of that file, you have to give it
> an appropriate name. Probably with a "batman_adv_" prefix or
> similar.

I aggree, but would like to like to have a shorter prefix batadv_. I know that
you said "or similar" but there are still some developers that fear your
response to a patch that only adds the prefix batadv_ instead of the longer
version.

Could you please approve or disapprove this proposal.

Thanks,
Sven

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]