From: Marek Lindner <lindner_marek@yahoo.de>
To: The list for a Better Approach To Mobile Ad-hoc Networking
<b.a.t.m.a.n@lists.open-mesh.org>
Subject: Re: [B.A.T.M.A.N.] [PATCH] batman-adv: fix locking in hash_add()
Date: Sat, 12 May 2012 03:50:20 +0800 [thread overview]
Message-ID: <201205120350.20936.lindner_marek@yahoo.de> (raw)
In-Reply-To: <5459592.26kVfpJHA4@sven-desktop.home.narfation.org>
On Wednesday, May 09, 2012 04:38:58 Sven Eckelmann wrote:
> Details
>
> On Tuesday 08 May 2012 22:31:57 Matthias Schiffer wrote:
> > To ensure an entry isn't added twice all comparisons have to be protected
> > by the hash line write spinlock. This doesn't really hurt as the case
> > that it is tried to add an element already present to the hash shouldn't
> > occur very often, so in most cases the lock would have have to be taken
> > anyways.
> >
> >
> >[..]
> >
> > -err_unlock:
> > - rcu_read_unlock();
> > +unlock:
> > + spin_unlock_bh(list_lock);
> >
> > out:
> > return ret;
> > }
>
> Acked-by: Sven Eckelmann <sven@narfation.org>
Applied in revision 41c5874.
Thanks,
Marek
prev parent reply other threads:[~2012-05-11 19:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-07 19:35 [B.A.T.M.A.N.] The current state of the batman-adv vis code Matthias Schiffer
2012-05-08 5:59 ` Marek Lindner
2012-05-08 14:18 ` Matthias Schiffer
2012-05-09 11:04 ` Marek Lindner
2012-05-09 14:59 ` Matthias Schiffer
2012-05-10 13:16 ` Marek Lindner
2012-05-08 20:31 ` [B.A.T.M.A.N.] [PATCH] batman-adv: fix locking in hash_add() Matthias Schiffer
2012-05-08 20:38 ` Sven Eckelmann
2012-05-11 19:50 ` Marek Lindner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201205120350.20936.lindner_marek@yahoo.de \
--to=lindner_marek@yahoo.de \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox