From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: Marek Lindner Date: Mon, 14 May 2012 16:21:25 +0800 References: <1336781383-15649-1-git-send-email-sven@narfation.org> <1336781383-15649-17-git-send-email-sven@narfation.org> In-Reply-To: <1336781383-15649-17-git-send-email-sven@narfation.org> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <201205141621.25425.lindner_marek@yahoo.de> Subject: Re: [B.A.T.M.A.N.] [PATCHv3 17/23] batman-adv: Prefix send non-static functions with batadv_ Reply-To: The list for a Better Approach To Mobile Ad-hoc Networking List-Id: The list for a Better Approach To Mobile Ad-hoc Networking List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: The list for a Better Approach To Mobile Ad-hoc Networking On Saturday, May 12, 2012 08:09:37 Sven Eckelmann wrote: > batman-adv can be compiled as part of the kernel instead of an module. In > that case the linker will see all non-static symbols of batman-adv and all > other non-static symbols of the kernel. This could lead to symbol > collisions. A prefix for the batman-adv symbols that defines their private > namespace avoids such a problem. > > Reported-by: David Miller > Signed-off-by: Sven Eckelmann > --- > bat_iv_ogm.c | 9 +++++---- > distributed-arp-table.c | 8 ++++++-- > hard-interface.c | 4 ++-- > icmp_socket.c | 2 +- > main.c | 2 +- > routing.c | 10 +++++----- > send.c | 22 ++++++++++++---------- > send.h | 17 +++++++++-------- > soft-interface.c | 2 +- > translation-table.c | 8 ++++---- > unicast.c | 6 +++--- > vis.c | 5 +++-- > 12 files changed, 52 insertions(+), 43 deletions(-) Applied in revision 8bad6dc. Thanks, Marek