From: Simon Wunderlich <simon.wunderlich@s2003.tu-chemnitz.de>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, b.a.t.m.a.n@lists.open-mesh.org,
Marek Lindner <lindner_marek@yahoo.de>
Subject: Re: [B.A.T.M.A.N.] [PATCH 06/15] batman-adv: Distributed ARP Table - add snooping functions for ARP messages
Date: Wed, 23 May 2012 23:48:02 +0200 [thread overview]
Message-ID: <20120523214802.GA12222@pandem0nium> (raw)
In-Reply-To: <201205171953.54891.lindner_marek@yahoo.de>
[-- Attachment #1: Type: text/plain, Size: 2755 bytes --]
Hello David,
we are a little bit in a pinch here - the DAT feature sent with this
patchset was developed for a long time, and we need your decision to move on
as more and more patches depend on it:
* should we rewrite DAT to use our own ARP table/backend or
* can we use the ARP neighbor table in another way, maybe after your changes?
We thought that re-using existing infrastructure would be smarter, but if
you disagree, please tell us so - we would like to get this feature finally
upstream and need your input to make the neccesary changes.
Thanks
Simon
On Thu, May 17, 2012 at 07:53:54PM +0800, Marek Lindner wrote:
>
> David,
>
> > On Tuesday, May 01, 2012 08:59:04 David Miller wrote:
> > > From: Antonio Quartulli <ordex@autistici.org>
> > > Date: Tue, 1 May 2012 00:22:30 +0200
> > >
> > > > However this patch also contains a procedure which queries the neigh
> > > > table in order to understand whether a given host is known or not.
> > > > Would it be possible to do that in another way (Without manually
> > > > touching the table)?
> > > >
> > > > Instead, in the next patch (patch 06/15) batman-adv manually increase
> > > > the neigh timeouts. Do you think we should avoid doing that as well?
> > > > If we are allowed to do that, how can we perform the same operation in
> > > > a cleaner way?
> > > >
> > > > Last question: why can't other modules use exported functions? Are you
> > > > going to change them as well?
> > >
> > > I really don't have time to discuss your neigh issues right now as I'm
> > > busy speaking at conferences and dealing with the backlog of other
> > > patches.
> > >
> > > You'll need to find someone else to discuss it with you, sorry.
> >
> > I hope now is a good moment to bring the questions back onto the table. We
> > still are not sure how to proceed because we have no clear picture of what
> > is going to come and how the exported functions are supposed to be used.
> >
> > David, if you don't have the time to discuss the ARP handling with us could
> > you name someone who knows your plans and the code equally well ? So far,
> > nobody has stepped up.
>
> let me add another piece of information: The distributed ARP table does not
> really depend on the kernel's ARP table. We can easily write our own backend
> to be totally independent of the kernel's ARP table. Initially, we thought it
> might be considered a smart move if the code made use of existing kernel
> infrastructure instead of writing our own storage / user space API / etc,
> hence duplicating what is already there. But if you feel this is the better
> way forward we certainly will make the necessary changes.
>
> Regards,
> Marek
>
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2012-05-23 21:48 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-29 8:57 [B.A.T.M.A.N.] pull request: batman-adv 2012-04-29 Antonio Quartulli
2012-04-29 8:57 ` [B.A.T.M.A.N.] [PATCH 01/15] batman-adv: add UNICAST_4ADDR packet type Antonio Quartulli
2012-04-29 8:57 ` [B.A.T.M.A.N.] [PATCH 02/15] batman-adv: add a new log level for DAT debugging Antonio Quartulli
2012-04-29 8:57 ` [B.A.T.M.A.N.] [PATCH 03/15] batman-adv: add biggest_unsigned_int(x) macro Antonio Quartulli
2012-04-29 8:57 ` [B.A.T.M.A.N.] [PATCH 04/15] batman-adv: Distributed ARP Table - create DHT helper functions Antonio Quartulli
2012-04-29 8:57 ` [B.A.T.M.A.N.] [PATCH 05/15] batman-adv: Distributed ARP Table - add ARP parsing functions Antonio Quartulli
2012-04-29 8:57 ` [B.A.T.M.A.N.] [PATCH 06/15] batman-adv: Distributed ARP Table - add snooping functions for ARP messages Antonio Quartulli
2012-04-30 17:05 ` David Miller
2012-04-30 22:22 ` Antonio Quartulli
2012-05-01 0:59 ` David Miller
2012-05-12 8:26 ` Marek Lindner
2012-05-17 11:53 ` Marek Lindner
2012-05-23 21:48 ` Simon Wunderlich [this message]
2012-05-23 23:01 ` David Miller
2012-05-24 5:34 ` Sven Eckelmann
2012-05-24 5:54 ` David Miller
2012-05-24 8:09 ` Simon Wunderlich
2012-04-29 8:57 ` [B.A.T.M.A.N.] [PATCH 07/15] batman-adv: Distributed ARP Table - increase default soft_iface ARP table timeout Antonio Quartulli
2012-04-29 8:57 ` [B.A.T.M.A.N.] [PATCH 08/15] batman-adv: Distributed ARP Table - add compile option Antonio Quartulli
2012-04-29 8:57 ` [B.A.T.M.A.N.] [PATCH 09/15] batman-adv: fix wrong dhcp option list browsing Antonio Quartulli
2012-04-29 8:57 ` [B.A.T.M.A.N.] [PATCH 10/15] batman-adv: introduce is_single_hop_neigh variable to increase readability Antonio Quartulli
2012-04-29 8:57 ` [B.A.T.M.A.N.] [PATCH 11/15] batman-adv: introduce packet type handler array for incoming packets Antonio Quartulli
2012-04-29 8:57 ` [B.A.T.M.A.N.] [PATCH 12/15] batman-adv: register batman ogm receive function during protocol init Antonio Quartulli
2012-04-29 8:57 ` [B.A.T.M.A.N.] [PATCH 13/15] batman-adv: rename last_valid to last_seen Antonio Quartulli
2012-04-29 8:57 ` [B.A.T.M.A.N.] [PATCH 14/15] batman-adv: replace HZ calculations with jiffies_to_msecs() Antonio Quartulli
2012-04-29 8:57 ` [B.A.T.M.A.N.] [PATCH 15/15] batman-adv: split neigh_new function into generic and batman iv specific parts Antonio Quartulli
-- strict thread matches above, loose matches on Subject: below --
2012-04-25 13:26 [B.A.T.M.A.N.] pull request: batman-adv 2012-04-25 Antonio Quartulli
2012-04-25 13:27 ` [B.A.T.M.A.N.] [PATCH 06/15] batman-adv: Distributed ARP Table - add snooping functions for ARP messages Antonio Quartulli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120523214802.GA12222@pandem0nium \
--to=simon.wunderlich@s2003.tu-chemnitz.de \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=davem@davemloft.net \
--cc=lindner_marek@yahoo.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox