From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: Marek Lindner Date: Sun, 10 Jun 2012 20:01:22 +0800 References: <1338928292-23085-1-git-send-email-sven@narfation.org> <1338928292-23085-6-git-send-email-sven@narfation.org> In-Reply-To: <1338928292-23085-6-git-send-email-sven@narfation.org> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <201206102001.23043.lindner_marek@yahoo.de> Subject: Re: [B.A.T.M.A.N.] [PATCH 6/6] batman-adv: Transform BATADV_LOG_BUFF(idx) into function Reply-To: The list for a Better Approach To Mobile Ad-hoc Networking List-Id: The list for a Better Approach To Mobile Ad-hoc Networking List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: The list for a Better Approach To Mobile Ad-hoc Networking On Wednesday, June 06, 2012 04:31:32 Sven Eckelmann wrote: > The linux Documentation/CodingStyle says that: > * Chapter 12: "inline functions are preferable to macros resembling > functions" * Chapter 12.2: Depending on local variables with a magic name > is bad * Chapter 12.3: Macros with arguments used as l-value are bad > > Signed-off-by: Sven Eckelmann > --- > bat_debugfs.c | 19 +++++++++++++++---- > 1 file changed, 15 insertions(+), 4 deletions(-) Applied in revision 4738c60. Thanks, Marek