* [B.A.T.M.A.N.] [PATCH 1/2] batman-adv: fix SIF show / store uint regression
@ 2012-06-10 14:05 Marek Lindner
2012-06-10 14:05 ` [B.A.T.M.A.N.] [PATCH 2/2] " Marek Lindner
2012-06-11 5:49 ` [B.A.T.M.A.N.] [PATCH 1/2] " Sven Eckelmann
0 siblings, 2 replies; 6+ messages in thread
From: Marek Lindner @ 2012-06-10 14:05 UTC (permalink / raw)
To: b.a.t.m.a.n; +Cc: Marek Lindner
Regression was introduced with commit: 98881e49
Signed-off-by: Marek Lindner <lindner_marek@yahoo.de>
---
bat_sysfs.c | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/bat_sysfs.c b/bat_sysfs.c
index e0272fe..e1ba286 100644
--- a/bat_sysfs.c
+++ b/bat_sysfs.c
@@ -135,8 +135,9 @@ ssize_t batadv_store_##_name(struct kobject *kobj, \
if (!hard_iface) \
return 0; \
\
- length = __store_uint_attr(buff, count, _min, _max, _post_func, \
- attr, &hard_iface->_name, net_dev); \
+ length = __batadv_store_uint_attr(buff, count, _min, _max, \
+ _post_func, attr, \
+ &hard_iface->_name, net_dev); \
\
hardif_free_ref(hard_iface); \
return length; \
--
1.7.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [B.A.T.M.A.N.] [PATCH 2/2] batman-adv: fix SIF show / store uint regression
2012-06-10 14:05 [B.A.T.M.A.N.] [PATCH 1/2] batman-adv: fix SIF show / store uint regression Marek Lindner
@ 2012-06-10 14:05 ` Marek Lindner
2012-06-11 5:49 ` Sven Eckelmann
2012-06-11 5:49 ` [B.A.T.M.A.N.] [PATCH 1/2] " Sven Eckelmann
1 sibling, 1 reply; 6+ messages in thread
From: Marek Lindner @ 2012-06-10 14:05 UTC (permalink / raw)
To: b.a.t.m.a.n; +Cc: Marek Lindner
Regression was introduced with commit: 36709939
Signed-off-by: Marek Lindner <lindner_marek@yahoo.de>
---
bat_sysfs.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/bat_sysfs.c b/bat_sysfs.c
index e1ba286..ca0bdda 100644
--- a/bat_sysfs.c
+++ b/bat_sysfs.c
@@ -139,7 +139,7 @@ ssize_t batadv_store_##_name(struct kobject *kobj, \
_post_func, attr, \
&hard_iface->_name, net_dev); \
\
- hardif_free_ref(hard_iface); \
+ batadv_hardif_free_ref(hard_iface); \
return length; \
}
@@ -157,7 +157,7 @@ ssize_t batadv_show_##_name(struct kobject *kobj, \
\
length = sprintf(buff, "%i\n", atomic_read(&hard_iface->_name));\
\
- hardif_free_ref(hard_iface); \
+ batadv_hardif_free_ref(hard_iface); \
return length; \
}
--
1.7.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [B.A.T.M.A.N.] [PATCH 1/2] batman-adv: fix SIF show / store uint regression
2012-06-10 14:05 [B.A.T.M.A.N.] [PATCH 1/2] batman-adv: fix SIF show / store uint regression Marek Lindner
2012-06-10 14:05 ` [B.A.T.M.A.N.] [PATCH 2/2] " Marek Lindner
@ 2012-06-11 5:49 ` Sven Eckelmann
2012-06-11 19:36 ` Marek Lindner
1 sibling, 1 reply; 6+ messages in thread
From: Sven Eckelmann @ 2012-06-11 5:49 UTC (permalink / raw)
To: b.a.t.m.a.n; +Cc: Marek Lindner
[-- Attachment #1: Type: text/plain, Size: 314 bytes --]
On Sunday 10 June 2012 22:05:40 Marek Lindner wrote:
> Regression was introduced with commit: 98881e49
>
> Signed-off-by: Marek Lindner <lindner_marek@yahoo.de>
Thanks for the fix. This part was in the code that I wanted to remove (but
you need in your next patch).
Acked-by: Sven Eckelmann <sven@narfation.org>
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [B.A.T.M.A.N.] [PATCH 1/2] batman-adv: fix SIF show / store uint regression
2012-06-11 5:49 ` [B.A.T.M.A.N.] [PATCH 1/2] " Sven Eckelmann
@ 2012-06-11 19:36 ` Marek Lindner
0 siblings, 0 replies; 6+ messages in thread
From: Marek Lindner @ 2012-06-11 19:36 UTC (permalink / raw)
To: The list for a Better Approach To Mobile Ad-hoc Networking
On Monday, June 11, 2012 13:49:27 Sven Eckelmann wrote:
> On Sunday 10 June 2012 22:05:40 Marek Lindner wrote:
> > Regression was introduced with commit: 98881e49
> >
> >
> >
> > Signed-off-by: Marek Lindner <lindner_marek@yahoo.de>
>
> Thanks for the fix. This part was in the code that I wanted to remove (but
> you need in your next patch).
>
> Acked-by: Sven Eckelmann <sven@narfation.org>
Applied in revision 535bb40.
Regards,
Marek
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-06-11 19:39 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-06-10 14:05 [B.A.T.M.A.N.] [PATCH 1/2] batman-adv: fix SIF show / store uint regression Marek Lindner
2012-06-10 14:05 ` [B.A.T.M.A.N.] [PATCH 2/2] " Marek Lindner
2012-06-11 5:49 ` Sven Eckelmann
2012-06-11 19:39 ` Marek Lindner
2012-06-11 5:49 ` [B.A.T.M.A.N.] [PATCH 1/2] " Sven Eckelmann
2012-06-11 19:36 ` Marek Lindner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox