From: Marek Lindner <lindner_marek@yahoo.de>
To: The list for a Better Approach To Mobile Ad-hoc Networking
<b.a.t.m.a.n@lists.open-mesh.org>
Subject: Re: [B.A.T.M.A.N.] [PATCH] batman-adv: fix skb->data assignment
Date: Sat, 16 Jun 2012 03:09:42 +0800 [thread overview]
Message-ID: <201206160309.43218.lindner_marek@yahoo.de> (raw)
In-Reply-To: <1339705288-4175-1-git-send-email-ordex@autistici.org>
On Friday, June 15, 2012 04:21:28 Antonio Quartulli wrote:
> skb_linearize(skb) possibly rearranges the skb internal data and then
> changes the skb->data pointer value. For this reason any other pointer in
> the code that was assigned skb->data before invoking skb_linearise(skb)
> must be re-assigned.
>
> In the current tt_query message handling code this is not done and
> therefore, in case of skb linearization, the pointer used to handle the
> packet header ends up in pointing to poisoned memory. The packet is then
> dropped but the translation-table mechanism is corrupted.
>
> Signed-off-by: Antonio Quartulli <ordex@autistici.org>
> ---
>
> *** this patch is an important fix and it is for maint ***
Next time you send a patch for maint, please be sure the patch is actually
based on maint. Your patch does not even apply on top of maint ...
Applied in revision c7d05ee.
Thanks,
Marek
next prev parent reply other threads:[~2012-06-15 19:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-14 20:21 [B.A.T.M.A.N.] [PATCH] batman-adv: fix skb->data assignment Antonio Quartulli
2012-06-15 11:45 ` Sven Eckelmann
2012-06-15 11:50 ` Antonio Quartulli
2012-06-15 19:09 ` Marek Lindner [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-06-19 7:20 Antonio Quartulli
2012-06-19 7:41 ` David Miller
2012-06-19 8:07 ` Sven Eckelmann
2012-06-19 9:02 ` David Miller
2012-06-19 9:51 ` Sven Eckelmann
2012-06-19 12:10 ` Ben Hutchings
2012-06-19 12:41 ` Sven Eckelmann
2012-06-19 7:23 Antonio Quartulli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201206160309.43218.lindner_marek@yahoo.de \
--to=lindner_marek@yahoo.de \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox