From: Marek Lindner <lindner_marek@yahoo.de>
To: The list for a Better Approach To Mobile Ad-hoc Networking
<b.a.t.m.a.n@lists.open-mesh.org>
Subject: Re: [B.A.T.M.A.N.] [PATCHv2 3/4] batman-adv: detect not yet announced clients
Date: Sat, 30 Jun 2012 12:01:25 +0200 [thread overview]
Message-ID: <201206301201.25953.lindner_marek@yahoo.de> (raw)
In-Reply-To: <1340785387-3821-4-git-send-email-ordex@autistici.org>
On Wednesday, June 27, 2012 10:23:06 Antonio Quartulli wrote:
> @@ -43,6 +43,10 @@
> #define BATADV_PURGE_TIMEOUT 200000 /* 200 seconds */
> #define BATADV_TT_LOCAL_TIMEOUT 3600000 /* in miliseconds */
> #define BATADV_TT_CLIENT_ROAM_TIMEOUT 600000 /* in miliseconds */
> +/* Used to compute the timeout value for the entries marked with
> TT_CLIENT_TEMP: + * temp_timeout_value = temp_timeout_fact * orig_int
> + */
> +#define BATADV_TT_CLIENT_TEMP_TIMEOUT_FACT 10UL
You implictely assume that all nodes have the originator interval which might
not be the case. As soon as they are different this will horribly fail.
Why not using the originator sequence number instead ? It will give you a time
independent timeout. You could say if we haven't received a TT ADD 3 sequence
numbers after we added the temporary client is gets merged.
Regards,
Marek
next prev parent reply other threads:[~2012-06-30 10:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-27 8:23 [B.A.T.M.A.N.] [PATCHv2 0/5] new feature: Speedy Join 2012-06-27 Antonio Quartulli
2012-06-27 8:23 ` [B.A.T.M.A.N.] [PATCHv2 1/4] batman-adv: add reference counting for type batadv_tt_orig_list_entry Antonio Quartulli
2012-06-30 9:55 ` Marek Lindner
2012-06-30 12:08 ` Antonio Quartulli
2012-06-27 8:23 ` [B.A.T.M.A.N.] [PATCHv2 2/4] batman-adv: implement batadv_tt_global_entry_get_orig() Antonio Quartulli
2012-06-30 9:56 ` Marek Lindner
2012-06-27 8:23 ` [B.A.T.M.A.N.] [PATCHv2 3/4] batman-adv: detect not yet announced clients Antonio Quartulli
2012-06-30 10:01 ` Marek Lindner [this message]
2012-06-30 12:12 ` Antonio Quartulli
2012-06-27 8:23 ` [B.A.T.M.A.N.] [PATCHv2 4/4] batman-adv: change interface_rx to get orig node Antonio Quartulli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201206301201.25953.lindner_marek@yahoo.de \
--to=lindner_marek@yahoo.de \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox