From: Antonio Quartulli <ordex@autistici.org>
To: The list for a Better Approach To Mobile Ad-hoc Networking
<b.a.t.m.a.n@lists.open-mesh.org>
Subject: Re: [B.A.T.M.A.N.] [RFC] batman-adv: Split batadv_priv in sub-structures for features
Date: Sun, 1 Jul 2012 14:19:37 +0200 [thread overview]
Message-ID: <20120701121937.GA2917@ritirata.org> (raw)
In-Reply-To: <1341144314-20995-1-git-send-email-sven@narfation.org>
[-- Attachment #1: Type: text/plain, Size: 967 bytes --]
On Sun, Jul 01, 2012 at 02:05:14PM +0200, Sven Eckelmann wrote:
> The structure batadv_priv grows everytime a new feature is introduced. It gets
> hard to find the parts of the struct that belongs to a specific feature. This
> becomes even harder by the fact that not every feature uses a prefix in the
> member name.
>
> The variables for bridge loop avoidence, gateway handling, translation table
> and visualization server are moved into separate structs that are included in
> the bat_priv main struct.
>
> Signed-off-by: Sven Eckelmann <sven@narfation.org>
> ---
> Any other ideas for substructs?
Hello Sven,
first of all thank you for taking care of this.
For what concerns the TT substructure it is fine with me, I had some doubt about
the ranaming of certain fields (ttvn -> tt.vn, and tt_crc -> tt.crc), but I
think they are ok.
Cheers,
--
Antonio Quartulli
..each of us alone is worth nothing..
Ernesto "Che" Guevara
[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2012-07-01 12:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-01 12:05 [B.A.T.M.A.N.] [RFC] batman-adv: Split batadv_priv in sub-structures for features Sven Eckelmann
2012-07-01 12:19 ` Antonio Quartulli [this message]
2012-07-02 8:09 ` Martin Hundebøll
2012-07-08 16:49 ` [B.A.T.M.A.N.] [PATCH] " Sven Eckelmann
2012-07-15 19:26 ` Antonio Quartulli
2012-07-15 19:42 ` Antonio Quartulli
2012-07-15 19:57 ` Sven Eckelmann
2012-07-15 20:26 ` [B.A.T.M.A.N.] [PATCHv2] " Sven Eckelmann
2012-07-16 9:51 ` Marek Lindner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120701121937.GA2917@ritirata.org \
--to=ordex@autistici.org \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox