From: Marek Lindner <lindner_marek@yahoo.de>
To: The list for a Better Approach To Mobile Ad-hoc Networking
<b.a.t.m.a.n@lists.open-mesh.org>
Subject: Re: [B.A.T.M.A.N.] [PATCH] batman-adv: use check_unicast_packet() in recv_roam_adv()
Date: Mon, 30 Jul 2012 09:56:51 +0200 [thread overview]
Message-ID: <201207300956.51449.lindner_marek@yahoo.de> (raw)
In-Reply-To: <1343602203-11584-1-git-send-email-ordex@autistici.org>
On Monday, July 30, 2012 00:50:03 Antonio Quartulli wrote:
> @@ -687,21 +687,9 @@ int batadv_recv_roam_adv(struct sk_buff *skb, struct
> batadv_hard_iface *recv_if) struct batadv_priv *bat_priv =
> netdev_priv(recv_if->soft_iface); struct batadv_roam_adv_packet
> *roam_adv_packet;
> struct batadv_orig_node *orig_node;
> - struct ethhdr *ethhdr;
> -
> - /* drop packet if it has not necessary minimum size */
> - if (unlikely(!pskb_may_pull(skb,
> - sizeof(struct batadv_roam_adv_packet))))
> - goto out;
> + int hdr_size = sizeof(struct batadv_roam_adv_packet);
Shouldn't we do: int hdr_size = sizeof(*roam_adv_packet); ?
Regards,
Marek
next prev parent reply other threads:[~2012-07-30 7:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-29 22:50 [B.A.T.M.A.N.] [PATCH] batman-adv: use check_unicast_packet() in recv_roam_adv() Antonio Quartulli
2012-07-30 7:56 ` Marek Lindner [this message]
2012-07-30 9:20 ` Antonio Quartulli
2012-07-31 12:12 ` [B.A.T.M.A.N.] [PATCHv2] " Antonio Quartulli
2012-07-31 15:19 ` [B.A.T.M.A.N.] [PATCHv3] " Antonio Quartulli
2012-08-21 23:36 ` Marek Lindner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201207300956.51449.lindner_marek@yahoo.de \
--to=lindner_marek@yahoo.de \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox