Re: [B.A.T.M.A.N.] [PATCH] batman-adv: pass the WIFI flag from the local to global entry

Antonio Quartulli
2012-07-30T10:16:33Z

[-- Attachment #1: Type: text/plain, Size: 1063 bytes --]

On Mon, Jul 30, 2012 at 12:12:19PM +0200, Marek Lindner wrote:
> On Monday, July 30, 2012 12:07:04 Antonio Quartulli wrote:
> > > And why is this explanation not part of the commit message ?
> >
> > Because it is left as exercise for the reader ;-)
> > Actually I didn't mention it because the Ap-Isolation part is a
> > "consequence". What this patch wants to fix is an issue in the client
> > entry state consistency, regardless of the semantic of such state.
> >
> > Anyhow, if you think it is worth adding it, I will do that.
>
> Well, we need some explanations *why* we want this change. The way you are
> describing it now it sounds like we want to preserve all relevant flags during
> the transition from local to global client and vice versa ?

Yes, that is the message I had in mind while writing the commit message. But ok,
I will send v2 and I'll be more verbose in order to let people understand what
this issue could lead to.

Cheers,

--
Antonio Quartulli

..each of us alone is worth nothing..
Ernesto "Che" Guevara

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]