From: Simon Wunderlich <simon.wunderlich@s2003.tu-chemnitz.de>
To: The list for a Better Approach To Mobile Ad-hoc Networking
<b.a.t.m.a.n@lists.open-mesh.org>
Subject: Re: [B.A.T.M.A.N.] [RFC] batman-adv: Set special lockdep classes to avoid lockdep warning
Date: Sun, 19 Aug 2012 09:57:48 +0200 [thread overview]
Message-ID: <20120819075748.GA7547@pandem0nium> (raw)
In-Reply-To: <1345361393-8759-1-git-send-email-sven@narfation.org>
[-- Attachment #1: Type: text/plain, Size: 2117 bytes --]
Hey Sven,
it works in my QEMU machines (and I could reproduce the bug report from 162).
Acked-by: Simon Wunderlich <siwu@hrz.tu-chemnitz.de>
(provided you add some sane commit message. ;] )
Cheers,
Simon
On Sun, Aug 19, 2012 at 09:29:53AM +0200, Sven Eckelmann wrote:
> [text will be added after I am awake... maybe]
>
> [Should be fix the problem found in bug 162... formerly known as 161. code
> stolen from macvlan... this is just a reimplementation of a solution proposed
> by Simon Wunderlich]
>
> Reported-by: Linus Lüssing <linus.luessing@web.de>
> Signed-off-by: Sven Eckelmann <sven@narfation.org>
> ---
> soft-interface.c | 29 +++++++++++++++++++++++++++++
> 1 file changed, 29 insertions(+)
>
> diff --git a/soft-interface.c b/soft-interface.c
> index 1aee7db..588c6f6 100644
> --- a/soft-interface.c
> +++ b/soft-interface.c
> @@ -344,7 +344,36 @@ out:
> return;
> }
>
> +/*
> + * batman-adv network devices have devices nesting below it and are a special
> + * "super class" of normal network devices; split their locks off into a
> + * separate class since they always nest.
> + */
> +static struct lock_class_key batadv_netdev_xmit_lock_key;
> +static struct lock_class_key batadv_netdev_addr_lock_key;
> +
> +static void batadv_set_lockdep_class_one(struct net_device *dev,
> + struct netdev_queue *txq,
> + void *_unused)
> +{
> + lockdep_set_class(&txq->_xmit_lock, &batadv_netdev_xmit_lock_key);
> +}
> +
> +static void batadv_set_lockdep_class(struct net_device *dev)
> +{
> + lockdep_set_class(&dev->addr_list_lock, &batadv_netdev_addr_lock_key);
> + netdev_for_each_tx_queue(dev, batadv_set_lockdep_class_one, NULL);
> +}
> +
> +static int batadv_softif_init(struct net_device *dev)
> +{
> + batadv_set_lockdep_class(dev);
> +
> + return 0;
> +}
> +
> static const struct net_device_ops batadv_netdev_ops = {
> + .ndo_init = batadv_softif_init,
> .ndo_open = batadv_interface_open,
> .ndo_stop = batadv_interface_release,
> .ndo_get_stats = batadv_interface_stats,
> --
> 1.7.10.4
>
>
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2012-08-19 7:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-19 7:29 [B.A.T.M.A.N.] [RFC] batman-adv: Set special lockdep classes to avoid lockdep warning Sven Eckelmann
2012-08-19 7:57 ` Simon Wunderlich [this message]
2012-08-19 23:22 ` [B.A.T.M.A.N.] [PATCH] " Sven Eckelmann
2012-08-20 7:00 ` Sven Eckelmann
2012-08-20 7:03 ` [B.A.T.M.A.N.] [PATCHv2] " Sven Eckelmann
2012-08-24 21:42 ` Marek Lindner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120819075748.GA7547@pandem0nium \
--to=simon.wunderlich@s2003.tu-chemnitz.de \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox