From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: Marek Lindner Date: Wed, 22 Aug 2012 02:28:43 +0200 References: <1344632966-24233-1-git-send-email-ordex@autistici.org> <1344676260-24951-1-git-send-email-ordex@autistici.org> In-Reply-To: <1344676260-24951-1-git-send-email-ordex@autistici.org> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <201208220228.44031.lindner_marek@yahoo.de> Subject: Re: [B.A.T.M.A.N.] [PATCHv2] batman-adv: return proper value in case of hash_add failure Reply-To: The list for a Better Approach To Mobile Ad-hoc Networking List-Id: The list for a Better Approach To Mobile Ad-hoc Networking List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: The list for a Better Approach To Mobile Ad-hoc Networking On Saturday, August 11, 2012 11:11:00 Antonio Quartulli wrote: > In case of hash_add failure tt_global_add() must return 0 (which means on > entry insertion). > > Signed-off-by: Antonio Quartulli > --- > > This patch is based on master. This bug exists since "a bit" but nobody > actually found it because this bug should have been triggered in the > unlikely case of hash > adding failure. Therefore I do not think it is a crucial bug and it is not > worth sending this patch to stable. > > Cheers, > > > translation-table.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied in revision 956c0b8. Thanks, Marek