Re: [B.A.T.M.A.N.] [PATCH] batman-adv: return proper value in case of hash_add failure

Sven Eckelmann
2012-08-11T08:58:12Z

On Fri, Aug 10, 2012 at 11:09:26PM +0200, Antonio Quartulli wrote:
> In case of hash_add failure tt_global_add() must return 0 (which means on entry
> insertion).
>
> Signed-off-by: Antonio Quartulli <ordex@autistici.org>
> ---
>
> This patch is based on master. This bug exists since "a bit" but nobody actually
> found it because this bug should have been triggered in the unlikely case of hash
> adding failure. Therefore I do not think it is a crucial bug and it is not worth
> sending this patch to stable.
>
> Cheers,
>
>
> Makefile | 2 +-
> translation-table.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index bd8d30c..12aebe5 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -20,7 +20,7 @@
>
> # changing the CONFIG_* line to 'y' enables the related feature
> # B.A.T.M.A.N. debugging:
> -export CONFIG_BATMAN_ADV_DEBUG=n
> +export CONFIG_BATMAN_ADV_DEBUG=y
> # B.A.T.M.A.N. bridge loop avoidance:
> export CONFIG_BATMAN_ADV_BLA=y

Sry, but disapproved.

Kind regards,
Sven