public inbox for b.a.t.m.a.n@lists.open-mesh.org
 help / color / mirror / Atom feed
From: Marek Lindner <lindner_marek@yahoo.de>
To: b.a.t.m.a.n@lists.open-mesh.org
Subject: Re: [B.A.T.M.A.N.] [PATCH 1/3] batman-adv: Remove extra check in batadv_bit_get_packet
Date: Fri, 24 Aug 2012 23:59:20 +0200	[thread overview]
Message-ID: <201208242359.21231.lindner_marek@yahoo.de> (raw)
In-Reply-To: <1345451209-8898-1-git-send-email-sven@narfation.org>

On Monday, August 20, 2012 10:26:47 Sven Eckelmann wrote:
> batadv_bit_get_packet checks for all common situations before it decides
> that the new received packet indicates that the host was restarted. This
> extra condition check at the end of the function is not necessary because
> this condition is always true.
> 
> This patch addresses Coverity #712296: Logically dead code
> 
> Signed-off-by: Sven Eckelmann <sven@narfation.org>
> ---
>  bitarray.c |   23 ++++++++++-------------
>  1 file changed, 10 insertions(+), 13 deletions(-)

Applied in revision d2da57c.

Thanks,
Marek

      parent reply	other threads:[~2012-08-24 21:59 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-20  8:26 [B.A.T.M.A.N.] [PATCH 1/3] batman-adv: Remove extra check in batadv_bit_get_packet Sven Eckelmann
2012-08-20  8:26 ` [B.A.T.M.A.N.] [PATCH 2/3] batman-adv: Check return value of try_module_get Sven Eckelmann
2012-08-20 21:37   ` [B.A.T.M.A.N.] [PATCHv3 " Sven Eckelmann
2012-08-24 22:08     ` Marek Lindner
2012-08-20  8:26 ` [B.A.T.M.A.N.] [PATCH 3/3] batman-adv: Only increase refcounter once for alternate router Sven Eckelmann
2012-08-24 22:19   ` Marek Lindner
2012-08-20 20:54 ` [B.A.T.M.A.N.] [PATCHv2 2/3] batman-adv: Check return value of try_module_get Sven Eckelmann
2012-08-24 21:59 ` Marek Lindner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201208242359.21231.lindner_marek@yahoo.de \
    --to=lindner_marek@yahoo.de \
    --cc=b.a.t.m.a.n@lists.open-mesh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox