From: Marek Lindner <lindner_marek@yahoo.de>
To: The list for a Better Approach To Mobile Ad-hoc Networking
<b.a.t.m.a.n@lists.open-mesh.org>
Subject: Re: [B.A.T.M.A.N.] [PATCH] batman-adv: roaming re-routing mechanism redesign
Date: Sun, 9 Sep 2012 16:29:57 +0800 [thread overview]
Message-ID: <201209091629.58178.lindner_marek@yahoo.de> (raw)
In-Reply-To: <1346339064-4348-1-git-send-email-ordex@autistici.org>
On Thursday, August 30, 2012 23:04:24 Antonio Quartulli wrote:
> The roaming re-routing procedure has been slightly revised in order to get
> rid of the tt_poss_change variable that was not clearly representing the
> node/client states. Now the code directly relies on the TT_CLIENT_ROAM
> flag that can be set on the involved local/global clients.
This seems to explain what another patch is doing ?
> - This patch is based on top of:
> "batman-adv: substitute tt_poss_change with a per-tt_entry flag"
Where is that patch ? I am unable to find it.
> +static void
> +batadv_tt_global_del_struct(struct batadv_priv *bat_priv,
> + struct batadv_tt_global_entry *tt_global_entry,
> + const char *message)
Can we come up with a better name than batadv_tt_global_del_struct ? "struct"
is a rather generic term.
> void batadv_tt_local_add(struct net_device *soft_iface, const uint8_t
> *addr, int ifindex)
> {
> struct batadv_priv *bat_priv = netdev_priv(soft_iface);
> - struct batadv_tt_local_entry *tt_local_entry = NULL;
> - struct batadv_tt_global_entry *tt_global_entry = NULL;
> + struct batadv_tt_local_entry *tt_local = NULL;
> + struct batadv_tt_global_entry *tt_global = NULL;
Please don't mix code changes with renames. That makes it hard to spot changes
in the behavior. Split these changes.
> + if (tt_local->common.flags & BATADV_TT_CLIENT_PENDING) {
> + /* if this client is marked as pending it means that it
> + * was purged out before.
> + */
Scratch "out".
> + batadv_dbg(BATADV_DBG_TT, bat_priv,
> + "Readding pending client %pM\n", addr);
Can you change it to "Re-adding" ?
> + /* if the entry is marked as NEW, it means that the node is not
> + * the original owner of this client (in this orig-interval),
> + * therefore it does need to eventually send a roaming
> + * advertisement
> + */
> + /*if (tt_local->common.flags & BATADV_TT_CLIENT_NEW)
> + goto out;*/
Dead code ?
Cheers,
Marek
next prev parent reply other threads:[~2012-09-09 8:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-30 15:04 [B.A.T.M.A.N.] [PATCH] batman-adv: roaming re-routing mechanism redesign Antonio Quartulli
2012-09-09 8:29 ` Marek Lindner [this message]
2012-09-09 8:43 ` Antonio Quartulli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201209091629.58178.lindner_marek@yahoo.de \
--to=lindner_marek@yahoo.de \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox