From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: Marek Lindner Date: Sun, 9 Sep 2012 16:34:50 +0800 References: <1346343747-4010-1-git-send-email-siwu@hrz.tu-chemnitz.de> In-Reply-To: <1346343747-4010-1-git-send-email-siwu@hrz.tu-chemnitz.de> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <201209091634.50908.lindner_marek@yahoo.de> Subject: Re: [B.A.T.M.A.N.] [PATCH] batman-adv: don't rely on positions in struct for hashing Reply-To: The list for a Better Approach To Mobile Ad-hoc Networking List-Id: The list for a Better Approach To Mobile Ad-hoc Networking List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: The list for a Better Approach To Mobile Ad-hoc Networking On Friday, August 31, 2012 00:22:27 Simon Wunderlich wrote: > The hash functions in the bridge loop avoidance code expects the > VLAN vid to be right after the mac address, but this is not guaranteed. > > Fix this by explicitly hashing over the right fields of the struct. > > Reported-by: Marek Lindner > Signed-off-by: Simon Wunderlich > --- > bridge_loop_avoidance.c | 32 ++++++++++++++++++-------------- > 1 file changed, 18 insertions(+), 14 deletions(-) Applied in revision 7e15c93. Thanks, Marek