From: Antonio Quartulli <ordex@autistici.org>
To: The list for a Better Approach To Mobile Ad-hoc Networking
<b.a.t.m.a.n@lists.open-mesh.org>
Subject: Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Fix change mac address of soft iface.
Date: Thu, 20 Sep 2012 13:42:50 +0200 [thread overview]
Message-ID: <20120920114250.GA29329@ritirata.org> (raw)
In-Reply-To: <1860743.fUGhpHrPxd@bentobox>
[-- Attachment #1: Type: text/plain, Size: 1150 bytes --]
Hello Def,
On Tue, Sep 18, 2012 at 04:55:32PM +0200, Sven Eckelmann wrote:
> On Tuesday 18 September 2012 16:41:58 Def wrote:
> > Into function interface_set_mac_addr, the function tt_local_add
> > was invoked before updating dev->dev_addr. The new MAC
> > addresse was not tagged as NoPurge.
> >
>
> Please don't add extra whitespaces before your commit message.
>
> Your Signed-off-by: is missing.
>
> [...]
> > -
> > - memcpy(dev->dev_addr, addr->sa_data, ETH_ALEN);
> > +
>
> Please don't add trailing whitespaces.
>
> I have no idea whether this works... *looks at Antonio*. But thanks for
> bringing this up in the issue tracker and sending this first version of the
> patch.
sorry for the delay. Overall the patch is correct, I also tested it and it
correctly fixes the problem.
Please, address what Sven just said so that the patch is clean (you can also use
checkpatch.pl --strict to check for this style things..it is in your
linux/scripts/ directory as documented in the file cited by Sven)
Cheers,
--
Antonio Quartulli
..each of us alone is worth nothing..
Ernesto "Che" Guevara
[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2012-09-20 11:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-18 14:41 [B.A.T.M.A.N.] [PATCH] batman-adv: Fix change mac address of soft iface Def
2012-09-18 14:55 ` Sven Eckelmann
2012-09-20 11:42 ` Antonio Quartulli [this message]
2012-09-20 12:56 ` [B.A.T.M.A.N.] [PATCHv2] " Def
2012-09-20 18:10 ` Antonio Quartulli
2012-09-23 8:42 ` Sven Eckelmann
2012-09-23 9:34 ` Marek Lindner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120920114250.GA29329@ritirata.org \
--to=ordex@autistici.org \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox