From: Marek Lindner <lindner_marek@yahoo.de>
To: The list for a Better Approach To Mobile Ad-hoc Networking
<b.a.t.m.a.n@lists.open-mesh.org>
Subject: Re: [B.A.T.M.A.N.] [PATCHv2] batman-adv: Fix symmetry check / route flapping in multi interface setups
Date: Sun, 23 Sep 2012 17:15:28 +0800 [thread overview]
Message-ID: <201209231715.28695.lindner_marek@yahoo.de> (raw)
In-Reply-To: <1347930068-7045-1-git-send-email-linus.luessing@web.de>
On Tuesday, September 18, 2012 09:01:08 Linus Lüssing wrote:
> @@ -743,7 +744,8 @@ batadv_iv_ogm_orig_update(struct batadv_priv *bat_priv,
> if (router && (neigh_node->tq_avg == router->tq_avg)) {
> orig_node_tmp = router->orig_node;
> spin_lock_bh(&orig_node_tmp->ogm_cnt_lock);
> - sum_orig =
> orig_node_tmp->bcast_own_sum[if_incoming->if_num]; + if_num
> = router->if_incoming->if_num;
> + sum_orig = orig_node_tmp->bcast_own_sum[if_num];
> spin_unlock_bh(&orig_node_tmp->ogm_cnt_lock);
>
> orig_node_tmp = neigh_node->orig_node;
Good catch! May I suggest another modifcation to make this section easier to
understand ? It won't change any behavior it just makes it easier to see where
if_num is coming from.
Cheers,
Marek
next prev parent reply other threads:[~2012-09-23 9:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-15 21:51 [B.A.T.M.A.N.] [PATCH] batman-adv: Fix symmetry check / route flapping in multi interface setups Linus Lüssing
2012-09-16 10:12 ` Antonio Quartulli
2012-09-18 1:01 ` [B.A.T.M.A.N.] [PATCHv2] " Linus Lüssing
2012-09-23 9:15 ` Marek Lindner [this message]
2012-09-23 9:16 ` [B.A.T.M.A.N.] [PATCHv3] " Marek Lindner
2012-09-23 10:44 ` "Linus Lüssing"
2012-09-23 15:18 ` Marek Lindner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201209231715.28695.lindner_marek@yahoo.de \
--to=lindner_marek@yahoo.de \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox