From: Marek Lindner <lindner_marek@yahoo.de>
To: The list for a Better Approach To Mobile Ad-hoc Networking
<b.a.t.m.a.n@lists.open-mesh.org>
Subject: Re: [B.A.T.M.A.N.] [RFC] batman-adv: dirty hack to recompute mac_len in the rx path
Date: Tue, 2 Oct 2012 13:16:40 +0800 [thread overview]
Message-ID: <201210021316.40830.lindner_marek@yahoo.de> (raw)
In-Reply-To: <1349124808-15995-1-git-send-email-siwu@hrz.tu-chemnitz.de>
On Tuesday, October 02, 2012 04:53:28 Simon Wunderlich wrote:
> +#define skb_share_check(skb, b) \
> + skb_share_check(skb, b); \
> + if (skb) \
> + skb_reset_mac_len(skb)
> +
> +#endif /* < KERNEL_VERSION(3, 8, 0) */
Has this patch been tested ? Our skb_share_check() call is this:
skb = skb_share_check(skb, GFP_ATOMIC);
Now we replace this function call with 2 function calls and 2 return values ?
Cheers,
Marek
next prev parent reply other threads:[~2012-10-02 5:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-15 12:34 [B.A.T.M.A.N.] [PATCH] batman-adv: recompute mac_len at the beginning of the rx path Antonio Quartulli
2012-09-29 11:27 ` Antonio Quartulli
2012-10-01 20:56 ` Simon Wunderlich
2012-10-01 20:53 ` [B.A.T.M.A.N.] [RFC] batman-adv: dirty hack to recompute mac_len in " Simon Wunderlich
2012-10-02 5:16 ` Marek Lindner [this message]
2012-10-02 9:37 ` Simon Wunderlich
2012-10-06 16:45 ` Sven Eckelmann
2012-10-14 12:46 ` [B.A.T.M.A.N.] [PATCH] " Simon Wunderlich
2012-10-14 18:53 ` Marek Lindner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201210021316.40830.lindner_marek@yahoo.de \
--to=lindner_marek@yahoo.de \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox