From: Antonio Quartulli <ordex@autistici.org>
To: The list for a Better Approach To Mobile Ad-hoc Networking
<b.a.t.m.a.n@lists.open-mesh.org>
Subject: Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Fix broadcast packet CRC calculation
Date: Wed, 17 Oct 2012 13:56:04 +0200 [thread overview]
Message-ID: <20121017115604.GO7023@ritirata.org> (raw)
In-Reply-To: <1350473910-27496-1-git-send-email-linus.luessing@web.de>
[-- Attachment #1: Type: text/plain, Size: 1075 bytes --]
On Wed, Oct 17, 2012 at 01:38:30PM +0200, Linus Lüssing wrote:
> So far the crc16 checksum for a batman-adv broadcast data packet, received
> on a batman-adv hard interface, was calculated over zero bytes of its
> content leading to many incoming broadcast data packets wrongly being
> dropped.
>
> This patch fixes this issue by calculating the crc16 over the actual,
> complete broadcast payload.
>
> The issue is a regrission introduced by
> e5cf86d30a9b32feccb6b866a3f23b0e0483a3b0.
>
> Signed-off-by: Linus Lüssing <linus.luessing@web.de>
Hi Linus,
nice catch!! Don't know how much time you spent to find the correct point where
your broadcast packets were getting lost.. :-)
Is it ok for you if we change the commit hash to ("batman-adv: add broadcast
duplicate check") when merging this patch? Lately Dave complained about commit
hashes in patch because it may happen that a developer uses a different hash
function for his git repo.
Cheers,
--
Antonio Quartulli
..each of us alone is worth nothing..
Ernesto "Che" Guevara
[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2012-10-17 11:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-17 11:38 [B.A.T.M.A.N.] [PATCH] batman-adv: Fix broadcast packet CRC calculation Linus Lüssing
2012-10-17 11:56 ` Antonio Quartulli [this message]
2012-10-20 4:18 ` Gui Iribarren
2012-10-17 13:32 ` Sven Eckelmann
2012-10-17 13:50 ` Sven Eckelmann
2012-10-17 13:51 ` Sven Eckelmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121017115604.GO7023@ritirata.org \
--to=ordex@autistici.org \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox