Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Fix broadcast packet CRC calculation

Antonio Quartulli
2012-10-17T11:56:04Z

[-- Attachment #1: Type: text/plain, Size: 1075 bytes --]

On Wed, Oct 17, 2012 at 01:38:30PM +0200, Linus Lüssing wrote:
> So far the crc16 checksum for a batman-adv broadcast data packet, received
> on a batman-adv hard interface, was calculated over zero bytes of its
> content leading to many incoming broadcast data packets wrongly being
> dropped.
>
> This patch fixes this issue by calculating the crc16 over the actual,
> complete broadcast payload.
>
> The issue is a regrission introduced by
> e5cf86d30a9b32feccb6b866a3f23b0e0483a3b0.
>
> Signed-off-by: Linus Lüssing <linus.luessing@web.de>

Hi Linus,

nice catch!! Don't know how much time you spent to find the correct point where
your broadcast packets were getting lost.. :-)

Is it ok for you if we change the commit hash to ("batman-adv: add broadcast
duplicate check") when merging this patch? Lately Dave complained about commit
hashes in patch because it may happen that a developer uses a different hash
function for his git repo.

Cheers,

--
Antonio Quartulli

..each of us alone is worth nothing..
Ernesto "Che" Guevara

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]