* [B.A.T.M.A.N.] [PATCH] batman-adv: Recommend not to change Makefile for configuration
@ 2012-10-18 9:43 Sven Eckelmann
2012-10-18 10:00 ` Marek Lindner
0 siblings, 1 reply; 2+ messages in thread
From: Sven Eckelmann @ 2012-10-18 9:43 UTC (permalink / raw)
To: b.a.t.m.a.n
The Makefile suggests to change it to enable or disable features. This resulted
in patch submissions with changed Makefile even when this change would not be
necessary.
Instead the configuration should be done using the make parameters explained in
README.external
Signed-off-by: Sven Eckelmann <sven@narfation.org>
---
Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Makefile b/Makefile
index c6266a2..4d70e40 100644
--- a/Makefile
+++ b/Makefile
@@ -18,7 +18,7 @@
# 02110-1301, USA
#
-# changing the CONFIG_* line to 'y' enables the related feature
+# read README.external for more information about the configuration
# B.A.T.M.A.N. debugging:
export CONFIG_BATMAN_ADV_DEBUG=n
# B.A.T.M.A.N. bridge loop avoidance:
--
1.7.10.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Recommend not to change Makefile for configuration
2012-10-18 9:43 [B.A.T.M.A.N.] [PATCH] batman-adv: Recommend not to change Makefile for configuration Sven Eckelmann
@ 2012-10-18 10:00 ` Marek Lindner
0 siblings, 0 replies; 2+ messages in thread
From: Marek Lindner @ 2012-10-18 10:00 UTC (permalink / raw)
To: b.a.t.m.a.n
On Thursday, October 18, 2012 17:43:54 Sven Eckelmann wrote:
> The Makefile suggests to change it to enable or disable features. This
> resulted in patch submissions with changed Makefile even when this change
> would not be necessary.
>
> Instead the configuration should be done using the make parameters
> explained in README.external
>
> Signed-off-by: Sven Eckelmann <sven@narfation.org>
> ---
> Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied in revision 4e3c233.
Thanks,
Marek
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-10-18 10:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-10-18 9:43 [B.A.T.M.A.N.] [PATCH] batman-adv: Recommend not to change Makefile for configuration Sven Eckelmann
2012-10-18 10:00 ` Marek Lindner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox