public inbox for b.a.t.m.a.n@lists.open-mesh.org
 help / color / mirror / Atom feed
From: Marek Lindner <lindner_marek@yahoo.de>
To: b.a.t.m.a.n@lists.open-mesh.org
Cc: Simon Wunderlich <siwu@hrz.tu-chemnitz.de>
Subject: Re: [B.A.T.M.A.N.] [PATCHv4] batman-adv: Fix broadcast duplist for fragmentation
Date: Sat, 27 Oct 2012 21:35:05 +0800	[thread overview]
Message-ID: <201210272135.06160.lindner_marek@yahoo.de> (raw)
In-Reply-To: <1350560862-2155-1-git-send-email-siwu@hrz.tu-chemnitz.de>

On Thursday, October 18, 2012 19:47:42 Simon Wunderlich wrote:
> If the skb is fragmented, the checksum must be computed on the
> individual fragments, just using skb->data may fail on fragmented
> data. Instead of doing linearizing the packet, use the new
> batadv_crc32 to do that more efficiently- it should not hurt
> replacing the old crc16 by the new crc32.
> 
> Reported-by: Sven Eckelmann <sven@narfation.org>
> Signed-off-by: Simon Wunderlich <siwu@hrz.tu-chemnitz.de>
> ---
> PATCHv2: change uint32_t to __be32
> PATCHv3: this time also changed in types.h
> PATCHv4: also compile if bla is disabled
> ---
>  bridge_loop_avoidance.c |   18 +++++++-----------
>  bridge_loop_avoidance.h |    6 ++----
>  routing.c               |   10 +++-------
>  types.h                 |    2 +-
>  4 files changed, 13 insertions(+), 23 deletions(-)

Applied in revision da14489.

Thanks,
Marek

      reply	other threads:[~2012-10-27 13:35 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-17 20:07 [B.A.T.M.A.N.] [PATCH] batman-adv: Fix broadcast duplist for fragmentation Simon Wunderlich
2012-10-17 20:20 ` [B.A.T.M.A.N.] [PATCHv2] " Simon Wunderlich
2012-10-17 20:28   ` [B.A.T.M.A.N.] [PATCHv3] " Simon Wunderlich
2012-10-18 11:47     ` [B.A.T.M.A.N.] [PATCHv4] " Simon Wunderlich
2012-10-27 13:35       ` Marek Lindner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201210272135.06160.lindner_marek@yahoo.de \
    --to=lindner_marek@yahoo.de \
    --cc=b.a.t.m.a.n@lists.open-mesh.org \
    --cc=siwu@hrz.tu-chemnitz.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox