From: Marek Lindner <lindner_marek@yahoo.de>
To: The list for a Better Approach To Mobile Ad-hoc Networking
<b.a.t.m.a.n@lists.open-mesh.org>
Subject: Re: [B.A.T.M.A.N.] [RFC] batman-adv: Reorder structs to reduce padding
Date: Tue, 6 Nov 2012 02:58:54 +0800 [thread overview]
Message-ID: <201211060258.54459.lindner_marek@yahoo.de> (raw)
In-Reply-To: <1351982508-16991-1-git-send-email-sven@narfation.org>
On Sunday, November 04, 2012 06:41:48 Sven Eckelmann wrote:
> - struct batadv_neigh_node __rcu *router; /* rcu protected pointer */
> #ifdef CONFIG_BATMAN_ADV_DAT
> batadv_dat_addr_t dat_addr;
> #endif
> + uint8_t flags;
> + uint8_t gw_flags;
> + struct batadv_neigh_node __rcu *router; /* rcu protected pointer */
Shouldn't we move batadv_dat_addr_t to the end of the struct to achieve the
smallest possible struct regardless of whether DAT is compiled in or not ? Or
does it have no effect ?
Cheers,
Marek
next prev parent reply other threads:[~2012-11-05 18:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-03 22:41 [B.A.T.M.A.N.] [RFC] batman-adv: Reorder structs to reduce padding Sven Eckelmann
2012-11-05 18:58 ` Marek Lindner [this message]
2012-11-16 19:17 ` Sven Eckelmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201211060258.54459.lindner_marek@yahoo.de \
--to=lindner_marek@yahoo.de \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox