From: Marek Lindner <lindner_marek@yahoo.de>
To: b.a.t.m.a.n@lists.open-mesh.org
Subject: Re: [B.A.T.M.A.N.] [PATCHv2 3/3] batman-adv: remove useless assignment in tt_local_add()
Date: Mon, 19 Nov 2012 16:17:22 +0800 [thread overview]
Message-ID: <201211191617.23637.lindner_marek@yahoo.de> (raw)
In-Reply-To: <1353312104-29333-3-git-send-email-ordex@autistici.org>
On Monday, November 19, 2012 16:01:44 Antonio Quartulli wrote:
> The flag field of the tt_local_entry->common structure in
> tt_local_add() is first assigned NO_FLAGS and then TT_CLIENT_NEW so
> nullifying the first operation. For this reason it is safe to remove
> the first assignment.
>
> This was introuduced by ("batman-adv: keep local table consistency for
> further TT_RESPONSE")
>
> Signed-off-by: Antonio Quartulli <ordex@autistici.org>
> ---
> translation-table.c | 12 +++++-------
> 1 file changed, 5 insertions(+), 7 deletions(-)
Applied in revision 1f59c6d.
Thanks,
Marek
next prev parent reply other threads:[~2012-11-19 8:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-19 8:01 [B.A.T.M.A.N.] [PATCHv2 1/3] batman-adv: print the CRC together with the translation tables Antonio Quartulli
2012-11-19 8:01 ` [B.A.T.M.A.N.] [PATCHv2 2/3] batman-adv: unify and properly print hex values Antonio Quartulli
2012-11-19 8:15 ` Marek Lindner
2012-11-19 8:01 ` [B.A.T.M.A.N.] [PATCHv2 3/3] batman-adv: remove useless assignment in tt_local_add() Antonio Quartulli
2012-11-19 8:17 ` Marek Lindner [this message]
2012-11-19 8:10 ` [B.A.T.M.A.N.] [PATCHv2 1/3] batman-adv: print the CRC together with the translation tables Marek Lindner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201211191617.23637.lindner_marek@yahoo.de \
--to=lindner_marek@yahoo.de \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox