Re: [B.A.T.M.A.N.] RFC: Removing one indirection layer for patches

[Antonio Quartulli <ordex@autistici.org>]

[-- Attachment #1: Type: text/plain, Size: 2376 bytes --]

On Wed, Dec 05, 2012 at 12:39:27PM +0100, Andrew Lunn wrote:
> > The biggest different is the "lets install a whole kernel to test this change" 
> > methodology ;)
> 
> Yes, i generally do that, test a whole kernel, not a module. But...
> 
> > Usually (please correct me) batman-adv is developed outside the kernel because 
> > it is easier to test stuff and it worked till now. No one of us wants to port 
> > the latest OpenWrt to the -rc kernel to test stuff ;)
> 
> Do you actually need to port to OpenWrt?
> 
> How i work is build a kernel, with everything i need built in. No
> modules. Then tftpboot the kernel, and use the rootfs from the
> disk. Why not do the same with OpenWrt?
> 
> > > It seems like the biggest problem is the late feedback from David
> > > S. Miller, et al, about patches. Getting this feedback earlier in the
> > > life of a patchset would easy people lives.
> > 
> > Partly, David switches horses relative often. So an early feedback is not as 
> > valuable as it sounds.
> 
> O.K. I've not paid enough attention to his comments to know this.
> 
> > > For Marvell work, we post all our patches to the linux arm kernel
> > > list, where the ARM maintainers will see the patches. All patches go
> > > there, in all stages of their life, from early RFCs, to patches we
> > > want the upstream maintainers to take in a following pull request.
> > > Thus there is the possibility to get early feedback from the upstream
> > > maintainers and avoid most last minutes surprises.
> > > 
> > > So maybe it would be good to stop using BATMAN mailing list for
> > > patches and instead use netdev. Or at least CC: netdev.
> > 
> > I'll tried it in the netdev_alloc/standard interface patchset but I got only a 
> > surprised "where is the pull request?" reply.
> 
> Humm, interesting. Is that maybe because BATMAN only ever sends pull
> requests to the list?

I think the main reason for this reply is that David was directly CCed.
I think we got no feedbacks because we are not used to send patches over
netdev "asking" for them.

However, if you look at all the other network "subtrees", everybody just sends
pull requests only. I think patches against "subtrees" are rarely sent to
netdev for feedback.

Cheers,

-- 
Antonio Quartulli

..each of us alone is worth nothing..
Ernesto "Che" Guevara

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]