From: Antonio Quartulli <ordex@autistici.org>
To: Marek Lindner <lindner_marek@yahoo.de>
Cc: The list for a Better Approach To Mobile Ad-hoc Networking
<b.a.t.m.a.n@lists.open-mesh.org>
Subject: Re: [B.A.T.M.A.N.] [PATCH] batman-adv: a delayed_work has to be initialised once
Date: Tue, 25 Dec 2012 11:51:23 +0100 [thread overview]
Message-ID: <20121225105123.GB2604@ritirata.org> (raw)
In-Reply-To: <201212251627.37792.lindner_marek@yahoo.de>
[-- Attachment #1: Type: text/plain, Size: 1054 bytes --]
On Tue, Dec 25, 2012 at 04:27:37 +0800, Marek Lindner wrote:
> On Saturday, December 15, 2012 21:10:56 Antonio Quartulli wrote:
> > - batadv_start_purge_timer(bat_priv);
> > + INIT_DELAYED_WORK(&bat_priv->orig_work, batadv_purge_orig);
> > + queue_delayed_work(batadv_event_workqueue,
> > + &bat_priv->orig_work, msecs_to_jiffies(1000));
> > +
> > return 0;
> >
> > err:
> > @@ -396,7 +392,8 @@ static void batadv_purge_orig(struct work_struct *work)
> > delayed_work = container_of(work, struct delayed_work, work);
> > bat_priv = container_of(delayed_work, struct batadv_priv, orig_work);
> > _batadv_purge_orig(bat_priv);
> > - batadv_start_purge_timer(bat_priv);
> > + queue_delayed_work(batadv_event_workqueue,
> > + &bat_priv->orig_work, msecs_to_jiffies(1000));
> > }
>
> If the same numeric value is used multiple times we should have a define.
>
Correct. I'll fix and resend.
Thanks a lot!
Cheers,
--
Antonio Quartulli
..each of us alone is worth nothing..
Ernesto "Che" Guevara
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-12-25 10:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-15 13:10 [B.A.T.M.A.N.] [PATCH] batman-adv: a delayed_work has to be initialised once Antonio Quartulli
2012-12-25 8:27 ` Marek Lindner
2012-12-25 10:51 ` Antonio Quartulli [this message]
2012-12-25 12:14 ` [B.A.T.M.A.N.] [PATCHv2] " Antonio Quartulli
2012-12-25 13:40 ` Marek Lindner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121225105123.GB2604@ritirata.org \
--to=ordex@autistici.org \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=lindner_marek@yahoo.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox