public inbox for b.a.t.m.a.n@lists.open-mesh.org
 help / color / mirror / Atom feed
From: Antonio Quartulli <ordex@autistici.org>
To: The list for a Better Approach To Mobile Ad-hoc Networking
	<b.a.t.m.a.n@lists.open-mesh.org>
Subject: Re: [B.A.T.M.A.N.] [PATCH] batman-adv: don't use !! in bool conversion
Date: Mon, 14 Jan 2013 14:33:26 +1000	[thread overview]
Message-ID: <20130114043326.GE2890@ritirata.org> (raw)
In-Reply-To: <201301141140.17187.lindner_marek@yahoo.de>

[-- Attachment #1: Type: text/plain, Size: 684 bytes --]

On Mon, Jan 14, 2013 at 11:40:17AM +0800, Marek Lindner wrote:
> On Monday, January 14, 2013 10:21:28 Antonio Quartulli wrote:
> > when converting an integer value to bool, whatever the length of the value
> > is, "!!" because of the standard Bool conversion definition
> 
> first of all, there is a verb missing somewhere. This sentence does not 
> compile.

whoops, true. Changed the sentence too many times.

> Secondly, it fails to explain *why* you are making that change.
> 

well, the "why" is implicit in the missing verb :D
"!! is useless". I'll send v2.

Cheers,



-- 
Antonio Quartulli

..each of us alone is worth nothing..
Ernesto "Che" Guevara

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

      reply	other threads:[~2013-01-14  4:33 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-14  2:21 [B.A.T.M.A.N.] [PATCH] batman-adv: don't use !! in bool conversion Antonio Quartulli
2013-01-14  3:40 ` Marek Lindner
2013-01-14  4:33   ` Antonio Quartulli [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130114043326.GE2890@ritirata.org \
    --to=ordex@autistici.org \
    --cc=b.a.t.m.a.n@lists.open-mesh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox