From: Antonio Quartulli <ordex@autistici.org>
To: Matthias Schiffer <mschiffer@universe-factory.net>
Cc: The list for a Better Approach To Mobile Ad-hoc Networking
<b.a.t.m.a.n@lists.open-mesh.org>
Subject: Re: [B.A.T.M.A.N.] [PATCH 2/2] batman-adv: filter out invalid DAT entries
Date: Thu, 24 Jan 2013 05:53:52 +0800 [thread overview]
Message-ID: <20130123215352.GD10344@ritirata.org> (raw)
In-Reply-To: <51005884.7090106@universe-factory.net>
[-- Attachment #1: Type: text/plain, Size: 887 bytes --]
On Wed, Jan 23, 2013 at 10:39:16PM +0100, Matthias Schiffer wrote:
> ipv4_is_zeronet() checks if the first byte of the address is zero, to my
> knowledge there is no special funtion for checking for the unspecified
> address, as the case is trivial and independent of byte ordering.
>
correct. Then the change you proposed is fine with me.
> It might make sense though to check for different types of addresses
> that are invalid for ARP (zeronet, loopback, multicast, etc.), but I
> wanted to keep the patch as simple as possible. If you think these
> should be filtered as well, I'll prepare a v2.
in distributed-arp-table.c:784 you can already find these checks ;)
I think at this point the patch is ok. Thanks a lot!
Acked-by: Antonio Quartulli <ordex@autistici.org>
--
Antonio Quartulli
..each of us alone is worth nothing..
Ernesto "Che" Guevara
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-01-23 21:53 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-23 17:11 [B.A.T.M.A.N.] [PATCH 1/2] batman-adv: fix skb leak in batadv_dat_snoop_incoming_arp_reply() Matthias Schiffer
2013-01-23 17:11 ` [B.A.T.M.A.N.] [PATCH 2/2] batman-adv: filter out invalid DAT entries Matthias Schiffer
2013-01-23 21:07 ` Antonio Quartulli
2013-01-23 21:39 ` Matthias Schiffer
2013-01-23 21:52 ` Matthias Schiffer
2013-01-23 21:55 ` Antonio Quartulli
2013-01-23 21:53 ` Antonio Quartulli [this message]
2013-01-24 13:36 ` Marek Lindner
2013-01-24 13:38 ` Antonio Quartulli
2013-01-24 13:47 ` Marek Lindner
2013-01-24 14:44 ` Matthias Schiffer
2013-01-24 15:12 ` Antonio Quartulli
2013-01-24 17:18 ` Matthias Schiffer
2013-01-24 17:18 ` [B.A.T.M.A.N.] [PATCH v2 1/2] batman-adv: check for more types of invalid IP addresses in DAT Matthias Schiffer
2013-01-24 17:18 ` [B.A.T.M.A.N.] [PATCH v2 2/2] batman-adv: filter ARP packets with invalid MAC " Matthias Schiffer
2013-01-24 17:33 ` Matthias Schiffer
2013-01-25 13:28 ` Antonio Quartulli
2013-01-27 0:38 ` Marek Lindner
2013-01-25 13:27 ` [B.A.T.M.A.N.] [PATCH v2 1/2] batman-adv: check for more types of invalid IP " Antonio Quartulli
2013-01-27 0:34 ` Marek Lindner
2013-01-23 21:11 ` [B.A.T.M.A.N.] [PATCH 1/2] batman-adv: fix skb leak in batadv_dat_snoop_incoming_arp_reply() Antonio Quartulli
2013-01-23 21:14 ` Antonio Quartulli
2013-01-24 13:31 ` Marek Lindner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130123215352.GD10344@ritirata.org \
--to=ordex@autistici.org \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=mschiffer@universe-factory.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox