Re: [B.A.T.M.A.N.] [PATCH 2/2] batman-adv: filter out invalid DAT entries

Marek Lindner
2013-01-24T13:36:11Z

On Thursday, January 24, 2013 05:53:52 Antonio Quartulli wrote:
> > It might make sense though to check for different types of addresses
> > that are invalid for ARP (zeronet, loopback, multicast, etc.), but I
> > wanted to keep the patch as simple as possible. If you think these
> > should be filtered as well, I'll prepare a v2.
>
> in distributed-arp-table.c:784 you can already find these checks ;)

If most of the checking is done in batadv_arp_get_type() why not moving these
checks there too ? That would allow to have all checks in the same place ?

Cheers,
Marek