[B.A.T.M.A.N.] [PATCH] batman-adv: Remove unused variable

[B.A.T.M.A.N.] [PATCH] batman-adv: Remove unused variable

[Emil Goode]

The commit ed242d01 removed a node parameter from iterators.
This patch removes a hlist_node struct that is no longer used.

Sparse gives a warning:

net/batman-adv/originator.c:411:21: warning:
	unused variable ‘node_tmp’ [-Wunused-variable]

Signed-off-by: Emil Goode <emilgoode@gmail.com>
---
 net/batman-adv/originator.c |    1 -
 1 file changed, 1 deletion(-)

diff --git a/net/batman-adv/originator.c b/net/batman-adv/originator.c
index 43d0f89..96fb80b 100644
--- a/net/batman-adv/originator.c
+++ b/net/batman-adv/originator.c
@@ -408,7 +408,6 @@ int batadv_orig_seq_print_text(struct seq_file *seq, void *offset)
 	struct net_device *net_dev = (struct net_device *)seq->private;
 	struct batadv_priv *bat_priv = netdev_priv(net_dev);
 	struct batadv_hashtable *hash = bat_priv->orig_hash;
-	struct hlist_node *node_tmp;
 	struct hlist_head *head;
 	struct batadv_hard_iface *primary_if;
 	struct batadv_orig_node *orig_node;
-- 
1.7.10.4

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Remove unused variable

[Antonio Quartulli]

[-- Attachment #1: Type: text/plain, Size: 747 bytes --]

Hi Emil,

On Wed, Feb 06, 2013 at 05:37:41 +0100, Emil Goode wrote:
> The commit ed242d01 removed a node parameter from iterators.
> This patch removes a hlist_node struct that is no longer used.
> 
> Sparse gives a warning:
> 
> net/batman-adv/originator.c:411:21: warning:
> 	unused variable ‘node_tmp’ [-Wunused-variable]
> 
> Signed-off-by: Emil Goode <emilgoode@gmail.com>

On which tree did you base your patch?
I cannot find the commit you are referring to (ed242d01) and the patch does not
apply (neither on net nor net-next).

Other than that the variable is used a couple of lines below (in the code we
have)...

Regards,

-- 
Antonio Quartulli

..each of us alone is worth nothing..
Ernesto "Che" Guevara

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Remove unused variable

[Emil Goode]

Hi Antonio,

The commit ed242d01 is in the linux-next tree and my patch depends on
that commit.

Best regards, Emil

On Wed, 2013-02-06 at 18:22 +0100, Antonio Quartulli wrote:
> Hi Emil,
> 
> On Wed, Feb 06, 2013 at 05:37:41 +0100, Emil Goode wrote:
> > The commit ed242d01 removed a node parameter from iterators.
> > This patch removes a hlist_node struct that is no longer used.
> > 
> > Sparse gives a warning:
> > 
> > net/batman-adv/originator.c:411:21: warning:
> > 	unused variable ‘node_tmp’ [-Wunused-variable]
> > 
> > Signed-off-by: Emil Goode <emilgoode@gmail.com>
> 
> On which tree did you base your patch?
> I cannot find the commit you are referring to (ed242d01) and the patch does not
> apply (neither on net nor net-next).
> 
> Other than that the variable is used a couple of lines below (in the code we
> have)...
> 
> Regards,
> 

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Remove unused variable

[Antonio Quartulli]

[-- Attachment #1: Type: text/plain, Size: 1559 bytes --]

Hi Emil,

On Wed, Feb 06, 2013 at 06:55:53 +0100, Emil Goode wrote:
> Hi Antonio,
> 
> The commit ed242d01 is in the linux-next tree and my patch depends on
> that commit.
> 

Yes, you are right. I was not aware of this commit, because the author
did not CC us (neither netdev) even if he changed the code we maintain.

As far as I can see that commit is in linux-next only.
Therefore it must be applied there.

However, I'd like you to change the commit message and write the full hash of
the commit you are referring to and its subject ("LIKE THIS"). This would make
it easier to find it.


Regards,

> Best regards, Emil
> 
> On Wed, 2013-02-06 at 18:22 +0100, Antonio Quartulli wrote:
> > Hi Emil,
> > 
> > On Wed, Feb 06, 2013 at 05:37:41 +0100, Emil Goode wrote:
> > > The commit ed242d01 removed a node parameter from iterators.
> > > This patch removes a hlist_node struct that is no longer used.
> > > 
> > > Sparse gives a warning:
> > > 
> > > net/batman-adv/originator.c:411:21: warning:
> > > 	unused variable ‘node_tmp’ [-Wunused-variable]
> > > 
> > > Signed-off-by: Emil Goode <emilgoode@gmail.com>
> > 
> > On which tree did you base your patch?
> > I cannot find the commit you are referring to (ed242d01) and the patch does not
> > apply (neither on net nor net-next).
> > 
> > Other than that the variable is used a couple of lines below (in the code we
> > have)...
> > 
> > Regards,
> > 
> 
> 

-- 
Antonio Quartulli

..each of us alone is worth nothing..
Ernesto "Che" Guevara

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Remove unused variable

[Emil Goode]

Hi Antonio,

If it is easier I can keep an eye on when the commit lands in the
net-next tree and then resend a modified version of the patch.
Or do you want me to resend it now?

Best regards, Emil

On Wed, 2013-02-06 at 20:55 +0100, Antonio Quartulli wrote:
> Hi Emil,
> 
> On Wed, Feb 06, 2013 at 06:55:53 +0100, Emil Goode wrote:
> > Hi Antonio,
> > 
> > The commit ed242d01 is in the linux-next tree and my patch depends on
> > that commit.
> > 
> 
> Yes, you are right. I was not aware of this commit, because the author
> did not CC us (neither netdev) even if he changed the code we maintain.
> 
> As far as I can see that commit is in linux-next only.
> Therefore it must be applied there.
> 
> However, I'd like you to change the commit message and write the full hash of
> the commit you are referring to and its subject ("LIKE THIS"). This would make
> it easier to find it.
> 
> 
> Regards,
> 
> > Best regards, Emil
> > 
> > On Wed, 2013-02-06 at 18:22 +0100, Antonio Quartulli wrote:
> > > Hi Emil,
> > > 
> > > On Wed, Feb 06, 2013 at 05:37:41 +0100, Emil Goode wrote:
> > > > The commit ed242d01 removed a node parameter from iterators.
> > > > This patch removes a hlist_node struct that is no longer used.
> > > > 
> > > > Sparse gives a warning:
> > > > 
> > > > net/batman-adv/originator.c:411:21: warning:
> > > > 	unused variable ‘node_tmp’ [-Wunused-variable]
> > > > 
> > > > Signed-off-by: Emil Goode <emilgoode@gmail.com>
> > > 
> > > On which tree did you base your patch?
> > > I cannot find the commit you are referring to (ed242d01) and the patch does not
> > > apply (neither on net nor net-next).
> > > 
> > > Other than that the variable is used a couple of lines below (in the code we
> > > have)...
> > > 
> > > Regards,
> > > 
> > 
> > 
> 

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Remove unused variable

[Antonio Quartulli]

[-- Attachment #1: Type: text/plain, Size: 2441 bytes --]

Hi Emil, 

On Wed, Feb 06, 2013 at 10:59:05 +0100, Emil Goode wrote:
> Hi Antonio,
> 
> If it is easier I can keep an eye on when the commit lands in the
> net-next tree and then resend a modified version of the patch.
> Or do you want me to resend it now?
> 

Well, that commit should be merged in net-next after the next merge window.

You can resend it now, but be sure to CC Stephen Rothwell
<sfr@canb.auug.org.au> (the linux-next maintainer) and to clearly state that the
patch is for linux-next.

Thanks.
Cheers,


p.s. try to do not top-post please :-)

> Best regards, Emil
> 
> On Wed, 2013-02-06 at 20:55 +0100, Antonio Quartulli wrote:
> > Hi Emil,
> > 
> > On Wed, Feb 06, 2013 at 06:55:53 +0100, Emil Goode wrote:
> > > Hi Antonio,
> > > 
> > > The commit ed242d01 is in the linux-next tree and my patch depends on
> > > that commit.
> > > 
> > 
> > Yes, you are right. I was not aware of this commit, because the author
> > did not CC us (neither netdev) even if he changed the code we maintain.
> > 
> > As far as I can see that commit is in linux-next only.
> > Therefore it must be applied there.
> > 
> > However, I'd like you to change the commit message and write the full hash of
> > the commit you are referring to and its subject ("LIKE THIS"). This would make
> > it easier to find it.
> > 
> > 
> > Regards,
> > 
> > > Best regards, Emil
> > > 
> > > On Wed, 2013-02-06 at 18:22 +0100, Antonio Quartulli wrote:
> > > > Hi Emil,
> > > > 
> > > > On Wed, Feb 06, 2013 at 05:37:41 +0100, Emil Goode wrote:
> > > > > The commit ed242d01 removed a node parameter from iterators.
> > > > > This patch removes a hlist_node struct that is no longer used.
> > > > > 
> > > > > Sparse gives a warning:
> > > > > 
> > > > > net/batman-adv/originator.c:411:21: warning:
> > > > > 	unused variable ‘node_tmp’ [-Wunused-variable]
> > > > > 
> > > > > Signed-off-by: Emil Goode <emilgoode@gmail.com>
> > > > 
> > > > On which tree did you base your patch?
> > > > I cannot find the commit you are referring to (ed242d01) and the patch does not
> > > > apply (neither on net nor net-next).
> > > > 
> > > > Other than that the variable is used a couple of lines below (in the code we
> > > > have)...
> > > > 
> > > > Regards,
> > > > 
> > > 
> > > 
> > 
> 
> 

-- 
Antonio Quartulli

..each of us alone is worth nothing..
Ernesto "Che" Guevara

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Remove unused variable

[Dan Carpenter]

On Wed, Feb 06, 2013 at 11:10:22PM +0100, Antonio Quartulli wrote:
> Hi Emil, 
> 
> On Wed, Feb 06, 2013 at 10:59:05 +0100, Emil Goode wrote:
> > Hi Antonio,
> > 
> > If it is easier I can keep an eye on when the commit lands in the
> > net-next tree and then resend a modified version of the patch.
> > Or do you want me to resend it now?
> > 
> 
> Well, that commit should be merged in net-next after the next merge window.
> 
> You can resend it now, but be sure to CC Stephen Rothwell
> <sfr@canb.auug.org.au> (the linux-next maintainer) and to clearly state that the
> patch is for linux-next.
> 

It doesn't go through Stephen Rothwell.  It goes through Andrew
Morton and it should be CC'd to Sasha Levin.

regards,
dan carpenter

[B.A.T.M.A.N.] [PATCH] batman-adv: remove unused variable

[Antonio Quartulli]

Actually unicast_4addr_packet in interface_rx() is set but never used and
therefore can be safely be removed.

Signed-off-by: Antonio Quartulli <ordex@autistici.org>
---
 soft-interface.c |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)

diff --git a/soft-interface.c b/soft-interface.c
index 8b68e01..92137af 100644
--- a/soft-interface.c
+++ b/soft-interface.c
@@ -259,7 +259,6 @@ void interface_rx(struct net_device *soft_iface,
 		  int hdr_size)
 {
 	struct bat_priv *bat_priv = netdev_priv(soft_iface);
-	struct unicast_4addr_packet *unicast_4addr_packet;
 	struct ethhdr *ethhdr;
 	struct vlan_ethhdr *vhdr;
 	short vid __maybe_unused = -1;
@@ -268,8 +267,6 @@ void interface_rx(struct net_device *soft_iface,
 	if (!pskb_may_pull(skb, hdr_size))
 		goto dropped;
 
-	unicast_4addr_packet = (struct unicast_4addr_packet *)skb->data;
-
 	if (dat_snoop_incoming_arp_request(bat_priv, skb, hdr_size))
 		goto out;
 
-- 
1.7.3.4

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: remove unused variable

[Marek Lindner]

On Monday, February 27, 2012 20:36:40 Antonio Quartulli wrote:
> Actually unicast_4addr_packet in interface_rx() is set but never used and
> therefore can be safely be removed.

Applied in revision 4ca2a01.

Thanks,
Marek