From: Antonio Quartulli <ordex@autistici.org>
To: The list for a Better Approach To Mobile Ad-hoc Networking
<b.a.t.m.a.n@lists.open-mesh.org>
Subject: Re: [B.A.T.M.A.N.] [PATCH 1/2] batman-adv: free an hard-interface before adding it
Date: Sat, 16 Feb 2013 13:34:08 +0100 [thread overview]
Message-ID: <20130216123407.GC3157@ritirata.org> (raw)
In-Reply-To: <201302162027.24930.lindner_marek@yahoo.de>
[-- Attachment #1: Type: text/plain, Size: 1238 bytes --]
On Sat, Feb 16, 2013 at 08:27:24PM +0800, Marek Lindner wrote:
> On Saturday, February 16, 2013 20:22:37 Marek Lindner wrote:
> > On Tuesday, February 12, 2013 23:21:55 Antonio Quartulli wrote:
> > > @@ -347,6 +342,13 @@ int batadv_hardif_enable_interface(struct
> > > batadv_hard_iface *hard_iface, goto err_dev;
> > >
> > > }
> > >
> > > + /* check if the interface is enslaved in another virtual one and
> > > + * in that case unlink it first
> > > + */
> > > + master = netdev_master_upper_dev_get(hard_iface->net_dev);
> > > + if (master)
> > > + netdev_upper_dev_unlink(hard_iface->net_dev, master);
> > > +
> > >
> > > hard_iface->soft_iface = soft_iface;
> > > bat_priv = netdev_priv(hard_iface->soft_iface);
> >
> > Seems we need some compat code here:
> >
> > hard-interface.c:348:2: error: implicit declaration of function
> > 'netdev_master_upper_dev_get'
>
> I wouldn't be surprised if netdev_upper_dev_unlink() also needed some compat
> code ...
netdev_upper_dev_unlink() is already in the compat code as it was needed by the
patcheset you have already merged this morning..
Cheers,
--
Antonio Quartulli
..each of us alone is worth nothing..
Ernesto "Che" Guevara
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-02-16 12:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-12 15:21 [B.A.T.M.A.N.] [PATCH 1/2] batman-adv: free an hard-interface before adding it Antonio Quartulli
2013-02-12 15:21 ` [B.A.T.M.A.N.] [PATCH 2/2] batman-adv: remove interfacing enslaving loop private check Antonio Quartulli
2013-02-16 12:22 ` [B.A.T.M.A.N.] [PATCH 1/2] batman-adv: free an hard-interface before adding it Marek Lindner
2013-02-16 12:27 ` Marek Lindner
2013-02-16 12:34 ` Antonio Quartulli [this message]
2013-02-16 12:35 ` Antonio Quartulli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130216123407.GC3157@ritirata.org \
--to=ordex@autistici.org \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox