Re: [B.A.T.M.A.N.] [PATCH 1/2] batman-adv: free an hard-interface before adding it

Antonio Quartulli
2013-02-16T12:34:08Z

[-- Attachment #1: Type: text/plain, Size: 1238 bytes --]

On Sat, Feb 16, 2013 at 08:27:24PM +0800, Marek Lindner wrote:
> On Saturday, February 16, 2013 20:22:37 Marek Lindner wrote:
> > On Tuesday, February 12, 2013 23:21:55 Antonio Quartulli wrote:
> > > @@ -347,6 +342,13 @@ int batadv_hardif_enable_interface(struct
> > > batadv_hard_iface *hard_iface, goto err_dev;
> > >
> > > }
> > >
> > > + /* check if the interface is enslaved in another virtual one and
> > > + * in that case unlink it first
> > > + */
> > > + master = netdev_master_upper_dev_get(hard_iface->net_dev);
> > > + if (master)
> > > + netdev_upper_dev_unlink(hard_iface->net_dev, master);
> > > +
> > >
> > > hard_iface->soft_iface = soft_iface;
> > > bat_priv = netdev_priv(hard_iface->soft_iface);
> >
> > Seems we need some compat code here:
> >
> > hard-interface.c:348:2: error: implicit declaration of function
> > 'netdev_master_upper_dev_get'
>
> I wouldn't be surprised if netdev_upper_dev_unlink() also needed some compat
> code ...

netdev_upper_dev_unlink() is already in the compat code as it was needed by the
patcheset you have already merged this morning..

Cheers,

--
Antonio Quartulli

..each of us alone is worth nothing..
Ernesto "Che" Guevara

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]