From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <simon.wunderlich@s2003.tu-chemnitz.de>
Date: Wed, 20 Feb 2013 15:14:13 +0100
From: Simon Wunderlich <simon.wunderlich@s2003.tu-chemnitz.de>
Message-ID: <20130220141413.GA1058@pandem0nium>
References: <1361112184-9927-1-git-send-email-ordex@autistici.org>
 <20130218234904.GA24241@pandem0nium>
 <201302190908.44891.lindner_marek@yahoo.de>
 <20130219214340.GA29174@pandem0nium>
 <20130220132625.GL3523@ritirata.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
 protocol="application/pgp-signature"; boundary="fdj2RfSjLxBAspz7"
Content-Disposition: inline
In-Reply-To: <20130220132625.GL3523@ritirata.org>
Subject: Re: [B.A.T.M.A.N.] [PATCH] batman-adv: add compat support for the
 new netlink ops
Reply-To: The list for a Better Approach To Mobile Ad-hoc Networking
 <b.a.t.m.a.n@lists.open-mesh.org>
List-Id: The list for a Better Approach To Mobile Ad-hoc Networking
 <b.a.t.m.a.n.lists.open-mesh.org>
List-Unsubscribe: <https://lists.open-mesh.org/mm/options/b.a.t.m.a.n>,
 <mailto:b.a.t.m.a.n-request@lists.open-mesh.org?subject=unsubscribe>
List-Archive: <http://lists.open-mesh.org/pipermail/b.a.t.m.a.n/>
List-Post: <mailto:b.a.t.m.a.n@lists.open-mesh.org>
List-Help: <mailto:b.a.t.m.a.n-request@lists.open-mesh.org?subject=help>
List-Subscribe: <https://lists.open-mesh.org/mm/listinfo/b.a.t.m.a.n>,
 <mailto:b.a.t.m.a.n-request@lists.open-mesh.org?subject=subscribe>
To: The list for a Better Approach To Mobile Ad-hoc Networking <b.a.t.m.a.n@lists.open-mesh.org>


--fdj2RfSjLxBAspz7
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Feb 20, 2013 at 02:26:25PM +0100, Antonio Quartulli wrote:
> Hi Simon,
>=20
> >=20
> > > ip link set dev $iface master bat0
> >=20
> > This doesn't work. eth0 is not added to batman. To further test, I've a=
dded
> > it via batctl.
>=20
> I'm not sure..but I think this does not work because the "set master" com=
mand
> does not use ioctl, but rtnl only. Since in this kernel we don't have rtn=
l for
> these operations (this is why we have this hacky patch) I did not expect =
this
> command to work.

OK

> > >=20
> > > Even more interesting are combinations of those:
> > > * batctl if add $iface && some OGMS here && ip link set dev $iface no=
master &&=20
> > > ip link del dev bat0
> > > * ip link add dev bat0 type batadv && ip link set dev $iface master b=
at0 &&=20
> > > some OGMS here && batctl if del $iface
> >=20
> > Some of these combinations are tested above, but I'd suggest we should =
fix the
> > general case first. :)
>=20
> what would you like to fix? :) We have just implemented a feature and now=
 we
> don't have any userspace tool which can exploit it! :-D

Well, if we don't expect this command to work then it's fine.

Personally I don't care as long as batctl works. :)

If there are any other things to test, please let me know.

Cheers,
	Simon


--fdj2RfSjLxBAspz7
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iEYEARECAAYFAlEk2jUACgkQrzg/fFk7axao/gCcDbnkQXFzqEg9GJ7Li7DcZYj7
dUsAoINqqP18Qsyku7Go75pT3YXGlNyk
=LL/j
-----END PGP SIGNATURE-----

--fdj2RfSjLxBAspz7--