From: Antonio Quartulli <ordex@autistici.org>
To: The list for a Better Approach To Mobile Ad-hoc Networking
<b.a.t.m.a.n@lists.open-mesh.org>
Subject: Re: [B.A.T.M.A.N.] [PATCH] batman-adv: add compat support for the new netlink ops
Date: Wed, 20 Feb 2013 15:27:27 +0100 [thread overview]
Message-ID: <20130220142727.GO3523@ritirata.org> (raw)
In-Reply-To: <20130220141413.GA1058@pandem0nium>
[-- Attachment #1: Type: text/plain, Size: 1827 bytes --]
On Wed, Feb 20, 2013 at 03:14:13PM +0100, Simon Wunderlich wrote:
> On Wed, Feb 20, 2013 at 02:26:25PM +0100, Antonio Quartulli wrote:
> > Hi Simon,
> >
> > >
> > > > ip link set dev $iface master bat0
> > >
> > > This doesn't work. eth0 is not added to batman. To further test, I've added
> > > it via batctl.
> >
> > I'm not sure..but I think this does not work because the "set master" command
> > does not use ioctl, but rtnl only. Since in this kernel we don't have rtnl for
> > these operations (this is why we have this hacky patch) I did not expect this
> > command to work.
>
> OK
>
> > > >
> > > > Even more interesting are combinations of those:
> > > > * batctl if add $iface && some OGMS here && ip link set dev $iface nomaster &&
> > > > ip link del dev bat0
> > > > * ip link add dev bat0 type batadv && ip link set dev $iface master bat0 &&
> > > > some OGMS here && batctl if del $iface
> > >
> > > Some of these combinations are tested above, but I'd suggest we should fix the
> > > general case first. :)
> >
> > what would you like to fix? :) We have just implemented a feature and now we
> > don't have any userspace tool which can exploit it! :-D
>
> Well, if we don't expect this command to work then it's fine.
I just double-checked. iplink handles the master subcommand by sending a rtnl
request with the IFLA_MASTER flasg set, nothing else. Unluckily, this flag is
not supported in 2.6.32.
>
> Personally I don't care as long as batctl works. :)
yeah, that's the important point. And batman-adv is still working with this
patch.
>
> If there are any other things to test, please let me know.
>
Nothing on my side.
Thanks again :)
Cheers,
--
Antonio Quartulli
..each of us alone is worth nothing..
Ernesto "Che" Guevara
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-02-20 14:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-17 14:43 [B.A.T.M.A.N.] [PATCH] batman-adv: add compat support for the new netlink ops Antonio Quartulli
2013-02-18 23:49 ` Simon Wunderlich
2013-02-19 1:08 ` Marek Lindner
2013-02-19 21:43 ` Simon Wunderlich
2013-02-20 13:26 ` Antonio Quartulli
2013-02-20 14:14 ` Simon Wunderlich
2013-02-20 14:27 ` Antonio Quartulli [this message]
2013-02-20 14:40 ` Antonio Quartulli
2013-02-20 14:57 ` [B.A.T.M.A.N.] [PATCHv2] " Antonio Quartulli
2013-02-26 21:28 ` Simon Wunderlich
2013-02-26 21:31 ` Antonio Quartulli
2013-02-27 3:20 ` Marek Lindner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130220142727.GO3523@ritirata.org \
--to=ordex@autistici.org \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox