public inbox for b.a.t.m.a.n@lists.open-mesh.org
 help / color / mirror / Atom feed
From: Marek Lindner <lindner_marek@yahoo.de>
To: b.a.t.m.a.n@lists.open-mesh.org
Subject: Re: [B.A.T.M.A.N.] [PATCHv3 1/2] batman-adv: free an hard-interface before adding it
Date: Wed, 27 Feb 2013 14:28:07 +0800	[thread overview]
Message-ID: <201302271428.07984.lindner_marek@yahoo.de> (raw)
In-Reply-To: <1361022160-25693-1-git-send-email-ordex@autistici.org>

On Saturday, February 16, 2013 21:42:39 Antonio Quartulli wrote:
> When adding a new hard interface (e.h. wlan0) to a soft interface (e.g.
> bat0) and the former is already enslaved in another virtual interface
> (e.g. a software bridge) batman-adv has to free the it first and then
> continue with the adding mechanism.
> 
> In this way the behaviour becomes consistent with what "ip link set master"
> does. At the moment batman-adv enslaves the hard interface without checking
> for the master device, possibly causing strange behaviours which are never
> wanted by the users.
> 
> Reported-by: Marek Lindner <lindner_marek@yahoo.de>
> Signed-off-by: Antonio Quartulli <ordex@autistici.org>
> ---
> v2:
>  - added compat code for netdev_master_upper_dev_get()
> v3:
>  - use #define instead of a static inline function in compat code
> 
>  compat.h         |  5 +++++
>  hard-interface.c | 14 ++++++++------
>  2 files changed, 13 insertions(+), 6 deletions(-)

Applied in revision 5e57e3b.

Thanks,
Marek

      parent reply	other threads:[~2013-02-27  6:28 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-16 13:42 [B.A.T.M.A.N.] [PATCHv3 1/2] batman-adv: free an hard-interface before adding it Antonio Quartulli
2013-02-16 13:42 ` [B.A.T.M.A.N.] [PATCHv3 2/2] batman-adv: remove interfacing enslaving loop private check Antonio Quartulli
2013-02-27 10:09   ` Marek Lindner
2013-02-27 10:21     ` Marek Lindner
2013-02-27 10:27       ` Antonio Quartulli
2013-02-27 10:41         ` Marek Lindner
2013-02-27  6:28 ` Marek Lindner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201302271428.07984.lindner_marek@yahoo.de \
    --to=lindner_marek@yahoo.de \
    --cc=b.a.t.m.a.n@lists.open-mesh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox