From: Marek Lindner <lindner_marek@yahoo.de>
To: The list for a Better Approach To Mobile Ad-hoc Networking
<b.a.t.m.a.n@lists.open-mesh.org>
Subject: Re: [B.A.T.M.A.N.] [PATCHv3 2/2] batman-adv: remove interfacing enslaving loop private check
Date: Wed, 27 Feb 2013 18:41:56 +0800 [thread overview]
Message-ID: <201302271841.56757.lindner_marek@yahoo.de> (raw)
In-Reply-To: <20130227102751.GY3523@ritirata.org>
On Wednesday, February 27, 2013 18:27:51 Antonio Quartulli wrote:
> On Wed, Feb 27, 2013 at 06:21:18PM +0800, Marek Lindner wrote:
> > On Wednesday, February 27, 2013 18:09:48 Marek Lindner wrote:
> > > On Saturday, February 16, 2013 21:42:40 Antonio Quartulli wrote:
> > > > Now that the new dev_upper API is used, the private check for
> > > > enslaving loops is not needed anymore as this is performed by the
> > > > new API itself.
> > >
> > > Are you sure ? Isn't the following supposed to fail:
> > >
> > > $ batctl if add eth0
> > > $ vconfig add bat0 5
> > > $ batctl if add bat0.5
> > >
> > > $ batctl if
> > >
> > > eth0: active
> > > bat0.5: active
> >
> > Without your patch this is what happens:
> >
> > $ batctl if add eth0
> > $ vconfig add bat0 5
> > $ batctl if add bat0.5
> >
> > Error - interface type not supported by batman-adv: bat0.5
>
> Are you testing this with < linux-3.9/net-next ?
> We need some compat stuff as if we want to remove this check and keep the
> behaviour on old kernels.
I am not running net-next. This is on linux 3.3.8.
Cheers,
Marek
next prev parent reply other threads:[~2013-02-27 10:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-16 13:42 [B.A.T.M.A.N.] [PATCHv3 1/2] batman-adv: free an hard-interface before adding it Antonio Quartulli
2013-02-16 13:42 ` [B.A.T.M.A.N.] [PATCHv3 2/2] batman-adv: remove interfacing enslaving loop private check Antonio Quartulli
2013-02-27 10:09 ` Marek Lindner
2013-02-27 10:21 ` Marek Lindner
2013-02-27 10:27 ` Antonio Quartulli
2013-02-27 10:41 ` Marek Lindner [this message]
2013-02-27 6:28 ` [B.A.T.M.A.N.] [PATCHv3 1/2] batman-adv: free an hard-interface before adding it Marek Lindner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201302271841.56757.lindner_marek@yahoo.de \
--to=lindner_marek@yahoo.de \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox