From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <lindner_marek@yahoo.de>
From: Marek Lindner <lindner_marek@yahoo.de>
Date: Wed, 27 Feb 2013 18:41:56 +0800
References: <1361022160-25693-1-git-send-email-ordex@autistici.org>
 <201302271821.19114.lindner_marek@yahoo.de>
 <20130227102751.GY3523@ritirata.org>
In-Reply-To: <20130227102751.GY3523@ritirata.org>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: 7bit
Message-Id: <201302271841.56757.lindner_marek@yahoo.de>
Subject: Re: [B.A.T.M.A.N.] [PATCHv3 2/2] batman-adv: remove interfacing
	enslaving loop private check
Reply-To: The list for a Better Approach To Mobile Ad-hoc Networking
 <b.a.t.m.a.n@lists.open-mesh.org>
List-Id: The list for a Better Approach To Mobile Ad-hoc Networking
 <b.a.t.m.a.n.lists.open-mesh.org>
List-Unsubscribe: <https://lists.open-mesh.org/mm/options/b.a.t.m.a.n>,
 <mailto:b.a.t.m.a.n-request@lists.open-mesh.org?subject=unsubscribe>
List-Archive: <http://lists.open-mesh.org/pipermail/b.a.t.m.a.n/>
List-Post: <mailto:b.a.t.m.a.n@lists.open-mesh.org>
List-Help: <mailto:b.a.t.m.a.n-request@lists.open-mesh.org?subject=help>
List-Subscribe: <https://lists.open-mesh.org/mm/listinfo/b.a.t.m.a.n>,
 <mailto:b.a.t.m.a.n-request@lists.open-mesh.org?subject=subscribe>
To: The list for a Better Approach To Mobile Ad-hoc Networking <b.a.t.m.a.n@lists.open-mesh.org>

On Wednesday, February 27, 2013 18:27:51 Antonio Quartulli wrote:
> On Wed, Feb 27, 2013 at 06:21:18PM +0800, Marek Lindner wrote:
> > On Wednesday, February 27, 2013 18:09:48 Marek Lindner wrote:
> > > On Saturday, February 16, 2013 21:42:40 Antonio Quartulli wrote:
> > > > Now that the new dev_upper API is used, the private check for
> > > > enslaving loops is not needed anymore as this is performed by the
> > > > new API itself.
> > > 
> > > Are you sure ? Isn't the following supposed to fail:
> > > 
> > > $ batctl if add eth0
> > > $ vconfig add bat0 5
> > > $ batctl if add bat0.5
> > > 
> > > $ batctl if
> > > 
> > >   eth0: active
> > >   bat0.5: active
> > 
> > Without your patch this is what happens:
> > 
> > $ batctl if add eth0
> > $ vconfig add bat0 5
> > $ batctl if add bat0.5
> > 
> >   Error - interface type not supported by batman-adv: bat0.5
> 
> Are you testing this with < linux-3.9/net-next ?
> We need some compat stuff as if we want to remove this check and keep the
> behaviour on old kernels.

I am not running net-next. This is on linux 3.3.8.

Cheers,
Marek