Re: [B.A.T.M.A.N.] [PATCHv3 2/2] batman-adv: remove interfacing enslaving loop private check

Antonio Quartulli
2013-02-27T10:27:51Z

[-- Attachment #1: Type: text/plain, Size: 1059 bytes --]

On Wed, Feb 27, 2013 at 06:21:18PM +0800, Marek Lindner wrote:
> On Wednesday, February 27, 2013 18:09:48 Marek Lindner wrote:
> > On Saturday, February 16, 2013 21:42:40 Antonio Quartulli wrote:
> > > Now that the new dev_upper API is used, the private check for enslaving
> > > loops is not needed anymore as this is performed by the new API itself.
> >
> > Are you sure ? Isn't the following supposed to fail:
> >
> > $ batctl if add eth0
> > $ vconfig add bat0 5
> > $ batctl if add bat0.5
> >
> > $ batctl if
> > eth0: active
> > bat0.5: active
>
> Without your patch this is what happens:
>
> $ batctl if add eth0
> $ vconfig add bat0 5
> $ batctl if add bat0.5
> Error - interface type not supported by batman-adv: bat0.5

Are you testing this with < linux-3.9/net-next ?
We need some compat stuff as if we want to remove this check and keep the
behaviour on old kernels.

Cheers,

/me does not think to old kernels :(

--
Antonio Quartulli

..each of us alone is worth nothing..
Ernesto "Che" Guevara

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]