From: Marek Lindner <lindner_marek@yahoo.de>
To: b.a.t.m.a.n@lists.open-mesh.org
Cc: "Martin Hundebøll" <martin@hundeboll.net>
Subject: Re: [B.A.T.M.A.N.] [PATCH next] batman-adv: Fix endianness errors for network coding
Date: Sat, 16 Mar 2013 18:09:04 +0800 [thread overview]
Message-ID: <201303161809.04428.lindner_marek@yahoo.de> (raw)
In-Reply-To: <1363293021-20505-1-git-send-email-martin@hundeboll.net>
On Friday, March 15, 2013 04:30:21 Martin Hundebøll wrote:
> Add a htonl() in network_coding.c when reading the sequence number
> from received ogm_packet, to avoid wrong byte ordering when comparing
> with a host value. This bug was introduced in
> 3ed7ada3f0bbcd058567bc0a8f9729a73eba7db6 ("batman-adv: network coding -
> detect coding nodes and remove these after timeout").
>
> Change the type of coded_packet->coded_len from uint16 to __be16 to
> avoid wrong assumptions about endianness in later uses. Introduced in
> c3289f3650d34b60296000a629c99f2488f7c3dd ("batman-adv: network coding -
> code and transmit packets if possible").
>
> Reported-by: Fengguang Wu <fengguang.wu@intel.com>
> Signed-off-by: Martin Hundebøll <martin@hundeboll.net>
> ---
> network-coding.c | 2 +-
> packet.h | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
Applied in revision a67d520.
Thanks,
Marek
prev parent reply other threads:[~2013-03-16 10:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-14 20:30 [B.A.T.M.A.N.] [PATCH next] batman-adv: Fix endianness errors for network coding Martin Hundebøll
2013-03-16 10:09 ` Marek Lindner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201303161809.04428.lindner_marek@yahoo.de \
--to=lindner_marek@yahoo.de \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=martin@hundeboll.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox