public inbox for b.a.t.m.a.n@lists.open-mesh.org
 help / color / mirror / Atom feed
From: Marek Lindner <lindner_marek@yahoo.de>
To: b.a.t.m.a.n@lists.open-mesh.org
Subject: Re: [B.A.T.M.A.N.] [PATCHv5 1/2] batman-adv: split batadv_is_wifi_iface() into two functions
Date: Sat, 16 Mar 2013 18:21:59 +0800	[thread overview]
Message-ID: <201303161821.59287.lindner_marek@yahoo.de> (raw)
In-Reply-To: <b6b8ee26c56ef0c28d1efe1c54218c4d7090bd98.1362867238.git.mschiffer@universe-factory.net>

On Sunday, March 10, 2013 06:14:22 Matthias Schiffer wrote:
> Previously batadv_is_wifi_iface() did two things at once: looking up a
> net_device from an interface index, and determining if it is a wifi device.
> 
> The second part is useful itself when the caller already has a net_device
> reference.
> 
> Signed-off-by: Matthias Schiffer <mschiffer@universe-factory.net>
> ---
>  hard-interface.c | 73
> +++++++++++++++++++++++++++++++------------------------- 1 file changed,
> 41 insertions(+), 32 deletions(-)

Applied in revision a75dbf4.

Thanks,
Marek


PS: Every new function is required to have kernel doc. This time I filled in 
the missing pieces but please do so in the future.

      parent reply	other threads:[~2013-03-16 10:21 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-09 10:33 [B.A.T.M.A.N.] [PATCHv2] batman-adv: send each broadcast only once on non-wireless interfaces Matthias Schiffer
2013-03-09 10:40 ` [B.A.T.M.A.N.] [PATCHv3] " Matthias Schiffer
2013-03-09 20:17   ` Antonio Quartulli
2013-03-09 21:18     ` [B.A.T.M.A.N.] [PATCHv4 1/2] batman-adv: split batadv_is_wifi_iface() into two functions Matthias Schiffer
2013-03-09 21:18       ` [B.A.T.M.A.N.] [PATCHv4 2/2] batman-adv: send each broadcast only once on non-wireless interfaces Matthias Schiffer
2013-03-09 22:14       ` [B.A.T.M.A.N.] [PATCHv5 1/2] batman-adv: split batadv_is_wifi_iface() into two functions Matthias Schiffer
2013-03-09 22:14         ` [B.A.T.M.A.N.] [PATCHv5 2/2] batman-adv: send each broadcast only once on non-wireless interfaces Matthias Schiffer
2013-03-16 10:31           ` Marek Lindner
2013-03-16 10:21         ` Marek Lindner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201303161821.59287.lindner_marek@yahoo.de \
    --to=lindner_marek@yahoo.de \
    --cc=b.a.t.m.a.n@lists.open-mesh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox