From: Marek Lindner <lindner_marek@yahoo.de>
To: The list for a Better Approach To Mobile Ad-hoc Networking
<b.a.t.m.a.n@lists.open-mesh.org>
Subject: Re: [B.A.T.M.A.N.] [PATCHv2] batman-adv: fix compat for Debian Wheezy kernel v3.2.39
Date: Sat, 16 Mar 2013 19:10:18 +0800 [thread overview]
Message-ID: <201303161910.18263.lindner_marek@yahoo.de> (raw)
In-Reply-To: <01f2a6ce4ab512c60760ce0275100750c5cd59bc.1363431558.git.mschiffer@universe-factory.net>
On Saturday, March 16, 2013 18:59:55 Matthias Schiffer wrote:
> @@ -174,10 +174,7 @@ static inline void skb_reset_mac_len(struct sk_buff
> *skb)
> #if LINUX_VERSION_CODE < KERNEL_VERSION(3, 4, 0)
>
> -static inline void eth_hw_addr_random(struct net_device *dev)
> -{
> - random_ether_addr(dev->dev_addr);
> -}
> +#define eth_hw_addr_random(dev) random_ether_addr((dev)->dev_addr)
>
> #endif /* < KERNEL_VERSION(3, 4, 0) */
How about re-defining the function name and keep the static inline ? There are
numerous examples of this in the compat.h file, for instance
batadv_this_cpu_add().
We also might want a comment there that we do this for Debian compat.
Cheers,
Marek
next prev parent reply other threads:[~2013-03-16 11:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-15 22:18 [B.A.T.M.A.N.] [PATCH] Fix compat for for Debian Wheezy kernel v3.2.39 Matthias Schiffer
2013-03-16 10:59 ` [B.A.T.M.A.N.] [PATCHv2] batman-adv: fix compat " Matthias Schiffer
2013-03-16 11:10 ` Marek Lindner [this message]
2013-03-16 11:30 ` [B.A.T.M.A.N.] [PATCHv3] " Matthias Schiffer
2013-03-18 8:25 ` Marek Lindner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201303161910.18263.lindner_marek@yahoo.de \
--to=lindner_marek@yahoo.de \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox