Re: [B.A.T.M.A.N.] Bug#703540: Inconsistent use of _GNU_SOURCE

[Michael Tautschnig <mt@debian.org>]

[-- Attachment #1: Type: text/plain, Size: 1589 bytes --]

Hi Sven, hi all,

[...]
> > Either all or no file should #define _GNU_SOURCE.
> 
> Please add information how to reproduce this the next time you are adding such 
> such a bug. Now I can just assume what you are writing is true (even when the 
> man page about sendto says otherwise). Not knowing how to reproduce it in the 
> best possible way just makes it harder for everyone to check the impact of the 
> problem.
> 

Just one question before I elaborate a bit: what information in the man page are
you referring to? I can't quite seem to see anything mentioning _GNU_SOURCE?

I fully understand your concerns and indeed it is a problem that I cannot quite
provide a concrete counterexample witnessing the problem. It may even be the
cast that, at present, this is only a potential problem and not a real one. It's
much like a compiler warning: ok to be ignored if you are doing it intentionally
and you are 100% sure you know what you are doing. In all other cases, however,
it is likely worth fixing, as the problem can only ever be found by link-time
type checking, which usual compilers can't do. Even if done, there is some
non-trivial effort required to tracing back the type inconsistency to
inconsistent order of #include or a missing #define.

The most I can provide right now is all the scripts that suffice to reproduce
the build results and error logs, to be found at
https://github.com/tautschnig/cprover-debian

> I've forwarded it to the upstream maintainer and attached the change for 
> Debian.
> 
[...]

Thanks!

Best,
Michael


[-- Attachment #2: Type: application/pgp-signature, Size: 833 bytes --]