From: Marek Lindner <lindner_marek@yahoo.de>
To: The list for a Better Approach To Mobile Ad-hoc Networking
<b.a.t.m.a.n@lists.open-mesh.org>
Subject: Re: [B.A.T.M.A.N.] [PATCH] batman-adv: do not silently ignore wrong condition
Date: Sat, 30 Mar 2013 23:01:29 +0800 [thread overview]
Message-ID: <201303302301.29913.lindner_marek@yahoo.de> (raw)
In-Reply-To: <1364654967-25455-1-git-send-email-ordex@autistici.org>
On Saturday, March 30, 2013 22:49:27 Antonio Quartulli wrote:
> @@ -669,7 +669,7 @@ batadv_iv_ogm_orig_update(struct batadv_priv *bat_priv,
> if (batadv_compare_eth(neigh_addr, ethhdr->h_source) &&
> tmp_neigh_node->if_incoming == if_incoming &&
> atomic_inc_not_zero(&tmp_neigh_node->refcount)) {
> - if (neigh_node)
> + if (WARN(neigh_node, "too many matching
> neigh_nodes") batadv_neigh_node_free_ref(neigh_node); neigh_node =
> tmp_neigh_node;
> continue;
I wasn't aware one could throw the warning right in the if-statement but for
the sake of readability, please don't do that.
Cheers,
Marek
next prev parent reply other threads:[~2013-03-30 15:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-30 14:49 [B.A.T.M.A.N.] [PATCH] batman-adv: do not silently ignore wrong condition Antonio Quartulli
2013-03-30 15:01 ` Marek Lindner [this message]
2013-03-30 15:09 ` Antonio Quartulli
2013-03-30 16:22 ` [B.A.T.M.A.N.] [PATCHv2] " Antonio Quartulli
2013-04-03 11:16 ` Marek Lindner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201303302301.29913.lindner_marek@yahoo.de \
--to=lindner_marek@yahoo.de \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox